Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebClient connection cache does not properly work with TLS #8682

Open
Verdent opened this issue Apr 19, 2024 · 0 comments
Open

WebClient connection cache does not properly work with TLS #8682

Verdent opened this issue Apr 19, 2024 · 0 comments
Assignees
Labels
Projects

Comments

@Verdent
Copy link
Member

Verdent commented Apr 19, 2024

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

Shared connection cache does not work properly when TLS is enabled. The problem is in the Tls class hashCode and equals implementations. SSLContext instance is used to calculate both of these, but it does not have any of these methods created on the SSLContext itself. Therefore even though SSLContext instance is the same in terms of the content/settings it is treated as not the same, since the default hashCode/equals is used.

Steps to reproduce

  1. Create two identical WebClients with TLS set (have also shared connection cache enabled)
  2. Execute request on both to the same endpoint on the same server
  3. Check shared connection cache. It contains two entries instead of one
@Verdent Verdent added bug Something isn't working webclient 4.x Version 4.x labels Apr 19, 2024
@Verdent Verdent added this to Triage in Backlog via automation Apr 19, 2024
@m0mus m0mus added P3 and removed bug Something isn't working labels Apr 25, 2024
@m0mus m0mus moved this from Triage to Sprint Scope in Backlog Apr 25, 2024
@Verdent Verdent moved this from Sprint Scope to High priority in Backlog May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Backlog
  
High priority
Development

No branches or pull requests

2 participants