Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x Track MP metrics TCK bug fix #7578

Open
tjquinno opened this issue Sep 13, 2023 · 1 comment · May be fixed by #8054
Open

4.x Track MP metrics TCK bug fix #7578

tjquinno opened this issue Sep 13, 2023 · 1 comment · May be fixed by #8054
Assignees
@tjquinno
Labels
4.x Version 4.x metrics MP P3 TCK
Projects
Backlog

Comments

@tjquinno
Copy link
Member

tjquinno commented Sep 13, 2023 •
edited

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

There is a bug in the MP metrics 5 TCK, recorded by this issue eclipse/microprofile-metrics#786, in which a metric that should be a gauge is actually tested as a counter.

(Update: separate issue eclipse/microprofile-metrics#787 covers the upcoming MP metrics 5.0.2 release).

The bug is planned to be fixed in 5.1.1. Once that change is in and Helidon adopts MP metrics 5.1.1 we'll need to change our implementation of this base metric accordingly.
@tjquinno tjquinno added this to Triage in Backlog via automation Sep 13, 2023
@m0mus m0mus added the P3 label Sep 18, 2023
@m0mus m0mus moved this from Triage to Normal priority in Backlog Sep 18, 2023
@tjquinno tjquinno mentioned this issue Nov 21, 2023
Closed
@tjquinno tjquinno added this to the 4.0.2 milestone Nov 21, 2023
@tjquinno tjquinno moved this from Normal priority to Sprint Scope in Backlog Nov 21, 2023
@tjquinno tjquinno moved this from Sprint Scope to In Progress in Backlog Nov 21, 2023
@tjquinno
Copy link
Member Author

There will also be an MP Metrics 5.0.2 release which is planned to include this fix.

Helidon plans to make a corresponding change and adopt 5.0.2 soon, currently targeted for Helidon 4.0.2.

@tjquinno tjquinno changed the title 4.x Track MP metrics 5.1.1 TCK bug fix 4.x Track MP metrics TCK bug fix Nov 21, 2023
@tjquinno tjquinno linked a pull request Nov 21, 2023 that will close this issue
Draft
@tjquinno tjquinno removed this from the 4.0.2 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjquinno tjquinno

Labels
4.x Version 4.x metrics MP P3 TCK
Projects
Backlog
  
In Progress
Milestone
No milestone
2 participants
@m0mus @tjquinno