Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust types based on selected game entry #16

Open
helblinglilly opened this issue Apr 21, 2024 · 0 comments
Open

Adjust types based on selected game entry #16

helblinglilly opened this issue Apr 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@helblinglilly
Copy link
Owner

helblinglilly commented Apr 21, 2024

This is mostly following this issue in PokeAPI: PokeAPI/pokeapi#1066

Currently, type labels are hard-coded to Gen 5 and shipped as part of the JS bundle - and Gen 5 labels should remain the default selection as they are the most readable without distraction.

But the setting "Show game specific sprites when possible" should also apply to type labels as it would ensure a more consistent experience for a user if they are currently playing through a certain game.

Scarlet/Violet type labels are still missing, so it might be good to contribute those.

The sprites have already been added to Github here: https://github.com/PokeAPI/sprites/tree/master/sprites/types but if the logic of "which sprite should be used" can be offloaded to the PokeAPI then that would be preferable.

@helblinglilly helblinglilly added the enhancement New feature or request label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant