You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, type labels are hard-coded to Gen 5 and shipped as part of the JS bundle - and Gen 5 labels should remain the default selection as they are the most readable without distraction.
But the setting "Show game specific sprites when possible" should also apply to type labels as it would ensure a more consistent experience for a user if they are currently playing through a certain game.
Scarlet/Violet type labels are still missing, so it might be good to contribute those.
This is mostly following this issue in PokeAPI: PokeAPI/pokeapi#1066
Currently, type labels are hard-coded to Gen 5 and shipped as part of the JS bundle - and Gen 5 labels should remain the default selection as they are the most readable without distraction.
But the setting "Show game specific sprites when possible" should also apply to type labels as it would ensure a more consistent experience for a user if they are currently playing through a certain game.
Scarlet/Violet type labels are still missing, so it might be good to contribute those.
The sprites have already been added to Github here: https://github.com/PokeAPI/sprites/tree/master/sprites/types but if the logic of "which sprite should be used" can be offloaded to the PokeAPI then that would be preferable.
The text was updated successfully, but these errors were encountered: