Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing "config" #38

Open
FreqBayes opened this issue May 8, 2023 · 4 comments · May be fixed by #43
Open

missing "config" #38

FreqBayes opened this issue May 8, 2023 · 4 comments · May be fixed by #43

Comments

@FreqBayes
Copy link

Hi, when I was trying to run the maxpooling example in 0.0.24 it gave me an AttributeError:

convolutional_2d_to_max_pooling_2d.py:170 in make_forward_pass_animation │
│ ❱ 170 │ │ │ │ axis=manim_ml.three_d_config.rotation_axis, │

I think it would be axis=manim_ml.config.three_d_config.rotation_axis

BTW, just wondering is it possible to specify the run_time of each layer? sometimes the ImageLayer plays very fast but Convolutional2DLayer plays too slow.
@DoctorDinosaur
Copy link

DoctorDinosaur commented Nov 7, 2023 •
edited

Same issue here. Tried from GitHub too with pip install git+https://github.com/helblazer811/ManimML.git

AttributeError: module 'manim_ml' has no attribute 'three_d_config'

@DoctorDinosaur DoctorDinosaur linked a pull request Nov 7, 2023 that will close this issue
Open
@DoctorDinosaur
Copy link

DoctorDinosaur commented Nov 7, 2023 •
edited

Pull request fixes the config error. But the animation is running painfully slowly unless you specify run_time, in which case imagelayer -> convolution is way too fast.

@helblazer811
Copy link
Owner

helblazer811 commented Nov 7, 2023 via email

@DoctorDinosaur
Copy link

Same code as https://github.com/helblazer811/ManimML/blob/main/examples/cnn/cnn_max_pool.py

Just adding a runtime arg to the self.play. Or not adding.

Without the anim is like 57 secs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AttributeError for three_d_config DoctorDinosaur/ManimML
3 participants
@helblazer811 @DoctorDinosaur @FreqBayes