Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'PurePosixPath' object has no attribute 'is_relative_to' #184

Open
tkocmathla opened this issue Apr 18, 2024 · 0 comments
Open

'PurePosixPath' object has no attribute 'is_relative_to' #184

tkocmathla opened this issue Apr 18, 2024 · 0 comments

Comments

@tkocmathla
Copy link

tkocmathla commented Apr 18, 2024

My environment has python 3.8, and when I run the refresh_compile_commands target, I get an error.

The target is configured as:

refresh_compile_commands(
    name = "refresh_compile_commands",
    exclude_external_sources = True,
    exclude_headers = "external",
)

The error is:

  File "<elided>/bazel-cache/9c934b8d76651a7ec8785c90c08dde0c/execroot/__main__/bazel-out/k8-fastbuild/bin/refresh_compile_commands.py", line 514, in _file_is_in_main_workspace_and_not_external
    if file_path.is_relative_to(pathlib.PurePath("external")):
AttributeError: 'PurePosixPath' object has no attribute 'is_relative_to'

Digging through the commit history here, I think this is an oversight from 0b821b7. In that commit, other uses of PosixPath.is_relative_to() were reverted back to use _is_relative_to(), but this one wasn't:

0b821b7#diff-a1d7061df7c566a1f7656624ec608ad53dd3aff7a7789b9b6e4866a3b1616042R508

It seems like this is the only remaining offender -- a search of .is_relative_to in the repo just finds this one case:
https://github.com/search?q=repo%3Ahedronvision%2Fbazel-compile-commands-extractor%20.is_relative_to&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant