Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: live status on "Analyzing" #148

Open
catskul opened this issue Dec 13, 2023 · 2 comments
Open

Feature request: live status on "Analyzing" #148

catskul opened this issue Dec 13, 2023 · 2 comments

Comments

@catskul
Copy link

catskul commented Dec 13, 2023

During >>> Analyzing commands used in @//... It can take quite a while before anything prints, or between things printing.

It might be helpful to have a status printout at the bottom of the screen which indicates that it's still working, and how many targets/total targets.

@cpsauer
Copy link
Contributor

cpsauer commented Dec 14, 2023

Hey man! I hear you, and thanks for taking the time to write in with feedback.

Currently we have this stuff from bazel shushed on the theory that it created a lot of noise, and that, probably, if it was taking a long time we should be coaching people to run after builds w/ the same flags so it can hit cache for the slow header search part--to run it on faster-running subsets of their code. Does that seem reasonable/applicable, or do you definitely want more logging?

I sadly don't have bandwidth for this one at the moment. Would you be interested in exploring? If so, there are two internal phases that are (sometimes) slow: (1) aquerying bazel (if v large) and (2) running header search (if can't hit cache from prior builds/runs of this tool). For (1) you could play with removing the silencing of bazel (go into the generated python and comment '--ui_event_filters=-info', and '--noshow_progress',. For (2) we could put TQDM or similar around the big threadpool.map, though we'd have to figure out how to get it to install nicely w/ Bazel. pip_parse and all that.

Thanks again,
Chris

@cpsauer
Copy link
Contributor

cpsauer commented Feb 1, 2024

We'd added rules_python, which would have made the tqdm install easy--and then had to revert because it had lots of issues :(

Reverted rules_python in 0b821b7.

Tracking restoration in #168, but that more or less blocks this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants