Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub link rendering forced dark #185

Open
heckj opened this issue Mar 8, 2020 · 2 comments
Open

epub link rendering forced dark #185

heckj opened this issue Mar 8, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@heckj
Copy link
Owner

heckj commented Mar 8, 2020

from reddit:

Just FYI, the links in the ePub version render as dark gray even when Books has a black background, making them hard to read. I'm not sure whether that's something you can fix for Books or have to change in general, just thought I'd let you know.

@heckj heckj added the enhancement New feature or request label Mar 8, 2020
@heckj
Copy link
Owner Author

heckj commented Mar 20, 2020

Related comment:

I would like to make one suggestion: I tend to read these books at night on my iPad (when I have time to focus) but there is an issue with your book when iBooks switches to dark mode. Several of the fonts become nearly invisible. I can manually force light mode but if you could address that it would be appreciated. One final comment: Please try using iBooks with your book on the iPad. I have found that several times everything hangs for 5-30 seconds - Cannot change page, etc. and then all of a sudden all the page changes occur. I also need to restart iBooks sometimes while reading your book. I am using an iPad Pro 10.5” with 13.3.1.

@heckj heckj self-assigned this Apr 1, 2020
@heckj heckj added bug Something isn't working and removed enhancement New feature or request labels Apr 1, 2020
@heckj
Copy link
Owner Author

heckj commented Apr 1, 2020

I did some digging into this, and it's definitely a side effect of the tooling I'm using and their default CSS settings. In some ways, it's fairly directly related to #30 - in that the CSS structure that's provided by my toolchain is intentionally constraining, ideally aimed at working on a large number of devices - but clearly not perfect.

Just to document it - I've checked this against two version of asciidoctor-epub3:

  • Asciidoctor EPUB3 1.5.0.alpha.9 using Asciidoctor 2.0.10
  • Asciidoctor EPUB3 1.5.0.alpha.12 using Asciidoctor 2.0.10

with substantially the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant