{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":308770,"defaultBranch":"main","name":"devise","ownerLogin":"heartcombo","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2009-09-16T12:15:12.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/59584037?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1712752048.0","currentOid":""},"activityList":{"items":[{"before":"d37ded59f57e4baf8424a8bf8a637033411b0984","after":"d18d6d833573e0bcef91347df679b502ca69e185","ref":"refs/heads/ca-mongoid","pushedAt":"2024-04-10T16:26:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Point to the latest release of mongoid instead of 8-1 branch\n\nNow that Mongoid has released new versions of 8.1 which contain the\nchanges we rely on for dirty tracking, we can just point our Gemfile to\ntheir released versions for testing against them.\n\nAlso update Rails and related dependencies to latest in the process, to\nmake sure they all match together. (Mongoid v8.1.2 didn't allow Rails 7.1\nfor instance, only v8.1.3+)","shortMessageHtmlLink":"Point to the latest release of mongoid instead of 8-1 branch"}},{"before":"a2f1d29b5975ad5f1bd68c1d7c0e9c22218fb687","after":"d37ded59f57e4baf8424a8bf8a637033411b0984","ref":"refs/heads/ca-mongoid","pushedAt":"2024-04-10T13:33:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Point to the latest release of mongoid instead of 8-1 branch\n\nNow that Mongoid has released new versions of 8.1 which contain the\nchanges we rely on for dirty tracking, we can just point our Gemfile to\ntheir released versions for testing against them.\n\nAlso update Rails and related dependencies to latest in the process, to\nmake sure they all match together. (Mongoid v8.1.2 didn't allow Rails 7.1\nfor instance, only v8.1.3+)","shortMessageHtmlLink":"Point to the latest release of mongoid instead of 8-1 branch"}},{"before":"bb2725c6e028f102c729bac053783ce9db03e789","after":"a2f1d29b5975ad5f1bd68c1d7c0e9c22218fb687","ref":"refs/heads/ca-mongoid","pushedAt":"2024-04-10T12:49:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Update dirty tracking to support Mongoid 8.0+\n\nIt appears Mongoid 8.0+ slightly [changed dirty tracking] behavior to\nmore closely match Active Model/Record, however they haven't yet\nintroduced the [new methods] that match the latest API, that seems to be\ncoming on Mongoid 8.1 only.\n\nThe changes here try to accommodate for that by determining which\n\"attribute_changed?\" method to call depending on whether the\n\"*_previously_*\" version exists. Newer versions of AR (5.1+) will\ncontinue to use the new API / methods, whereas previous versions and\nMongoid 8.0+ will use these tweaked versions. No behavior should change\nfor AR, but it will hopefully support Mongoid 8.0+ now.\n\n[changed dirty tracking]\nhttps://github.com/mongodb/mongoid/pull/5092\n\n[new methods]\nhttps://github.com/mongodb/mongoid/pull/5440","shortMessageHtmlLink":"Update dirty tracking to support Mongoid 8.0+"}},{"before":"9a7176f727131423f95726ebcda64d498cddc3fc","after":"a259ff3c28912a27329727f4a3c2623d3f5cb6f2","ref":"refs/heads/main","pushedAt":"2024-04-10T12:46:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Make it clearer that we're targeting a v5 going forward\n\nUse a \"beta\" version to make that even more explicit.","shortMessageHtmlLink":"Make it clearer that we're targeting a v5 going forward"}},{"before":"21deb5c14514e095cb0c496cd48f03888c51b880","after":"9a7176f727131423f95726ebcda64d498cddc3fc","ref":"refs/heads/main","pushedAt":"2024-04-10T12:44:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Cleanup changelog, point to 4-stable branch for previous changes\n\nmain is targetting a v5 with some possible breaking changes, for main\nit's mainly dropping support for older Ruby/Rails versions, but more\nmight come.\n\n[ci skip]","shortMessageHtmlLink":"Cleanup changelog, point to 4-stable branch for previous changes"}},{"before":"bab47e1c1f45ca7d9e635ab9e80ac663f08eb151","after":"d5a48b49dcb95941f864180296ad68683e205edc","ref":"refs/heads/4-stable","pushedAt":"2024-04-10T12:27:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Release v4.9.4","shortMessageHtmlLink":"Release v4.9.4"}},{"before":"e3e17424bb5577426091289b318c13614d5c7eb2","after":null,"ref":"refs/heads/ca-test-3-3-on-4-stable","pushedAt":"2024-04-09T20:13:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"}},{"before":"cee7457d7f41f0ff7251ec75a13ef8bf08594cdd","after":"bab47e1c1f45ca7d9e635ab9e80ac663f08eb151","ref":"refs/heads/4-stable","pushedAt":"2024-04-09T20:12:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Adds Ruby 3.3 to CI on 4-stable\n\nRelated: #5668","shortMessageHtmlLink":"Adds Ruby 3.3 to CI on 4-stable"}},{"before":"d9eb3a50b91abee6c80095534d1c41c100e9162f","after":"bb2725c6e028f102c729bac053783ce9db03e789","ref":"refs/heads/ca-mongoid","pushedAt":"2024-04-09T20:03:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Update dirty tracking to support Mongoid 8.0+\n\nIt appears Mongoid 8.0+ slightly [changed dirty tracking] behavior to\nmore closely match Active Model/Record, however they haven't yet\nintroduced the [new methods] that match the latest API, that seems to be\ncoming on Mongoid 8.1 only.\n\nThe changes here try to accommodate for that by determining which\n\"attribute_changed?\" method to call depending on whether the\n\"*_previously_*\" version exists. Newer versions of AR (5.1+) will\ncontinue to use the new API / methods, whereas previous versions and\nMongoid 8.0+ will use these tweaked versions. No behavior should change\nfor AR, but it will hopefully support Mongoid 8.0+ now.\n\n[changed dirty tracking]\nhttps://github.com/mongodb/mongoid/pull/5092\n\n[new methods]\nhttps://github.com/mongodb/mongoid/pull/5440","shortMessageHtmlLink":"Update dirty tracking to support Mongoid 8.0+"}},{"before":"6ee12d1521e426f3a8d1622ea26db2c926654637","after":"21deb5c14514e095cb0c496cd48f03888c51b880","ref":"refs/heads/main","pushedAt":"2024-04-09T19:59:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Bump year [ci skip]","shortMessageHtmlLink":"Bump year [ci skip]"}},{"before":"95ed7d3dd86257c8a62619563f8bac74d481ed9f","after":"cee7457d7f41f0ff7251ec75a13ef8bf08594cdd","ref":"refs/heads/4-stable","pushedAt":"2024-04-09T19:59:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Bump year [ci skip]","shortMessageHtmlLink":"Bump year [ci skip]"}},{"before":"1b19ea411875d2dbfa0827e3924a63349e6535b5","after":"e3e17424bb5577426091289b318c13614d5c7eb2","ref":"refs/heads/ca-test-3-3-on-4-stable","pushedAt":"2024-04-09T17:36:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Adds Ruby 3.3 to CI on 4-stable\n\nRelated: #5668","shortMessageHtmlLink":"Adds Ruby 3.3 to CI on 4-stable"}},{"before":"35ae8225f616af3ebba53015d2add8704f89396d","after":"1b19ea411875d2dbfa0827e3924a63349e6535b5","ref":"refs/heads/ca-test-3-3-on-4-stable","pushedAt":"2024-04-09T17:31:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Merge pull request #5668 from berkos/update-ci\n\nAdds Ruby 3.3 to CI","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2062377177\" data-permission-text=\"Title is private\" data-url=\"https://github.com/heartcombo/devise/issues/5668\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/heartcombo/devise/pull/5668/hovercard\" href=\"https://github.com/heartcombo/devise/pull/5668\">#5668</a> from berkos/update-ci"}},{"before":null,"after":"35ae8225f616af3ebba53015d2add8704f89396d","ref":"refs/heads/ca-test-3-3-on-4-stable","pushedAt":"2024-04-09T17:22:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Add changelog about Ruby 3.3 [ci skip]","shortMessageHtmlLink":"Add changelog about Ruby 3.3 [ci skip]"}},{"before":"bb18f4d3805be0bf5f45e21be39625c7cfd9c1d6","after":"6ee12d1521e426f3a8d1622ea26db2c926654637","ref":"refs/heads/main","pushedAt":"2024-04-09T17:20:06.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Merge pull request #5668 from berkos/update-ci\n\nAdds Ruby 3.3 to CI","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2062377177\" data-permission-text=\"Title is private\" data-url=\"https://github.com/heartcombo/devise/issues/5668\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/heartcombo/devise/pull/5668/hovercard\" href=\"https://github.com/heartcombo/devise/pull/5668\">#5668</a> from berkos/update-ci"}},{"before":"e2242a95f3bb2e68ec0e9a064238ff7af6429545","after":"bb18f4d3805be0bf5f45e21be39625c7cfd9c1d6","ref":"refs/heads/main","pushedAt":"2024-02-13T12:22:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Update mapping.rb (#5673)\n\nFix grammar on comment for .find_scope! [ci skip]","shortMessageHtmlLink":"Update mapping.rb (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2131025893\" data-permission-text=\"Title is private\" data-url=\"https://github.com/heartcombo/devise/issues/5673\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/heartcombo/devise/pull/5673/hovercard\" href=\"https://github.com/heartcombo/devise/pull/5673\">#5673</a>)"}},{"before":"ffc58c073e14d6d0ef97e00a8ea66d0219bef6fc","after":null,"ref":"refs/heads/dependabot/github_actions/supercharge/mongodb-github-action-1.10.0","pushedAt":"2023-10-13T14:59:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"}},{"before":"d3afea2a91e32c4c3fd852eaa2eda37278acb900","after":null,"ref":"refs/heads/dependabot/github_actions/actions/checkout-4","pushedAt":"2023-10-13T14:59:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"}},{"before":"edffc79bf05d7f1c58ba50ffeda645e2e4ae0cb1","after":"95ed7d3dd86257c8a62619563f8bac74d481ed9f","ref":"refs/heads/4-stable","pushedAt":"2023-10-13T14:57:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Merge pull request #5641 from henryaj/patch-1\n\nFix README anchor link [ci skip]","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1942115862\" data-permission-text=\"Title is private\" data-url=\"https://github.com/heartcombo/devise/issues/5641\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/heartcombo/devise/pull/5641/hovercard\" href=\"https://github.com/heartcombo/devise/pull/5641\">#5641</a> from henryaj/patch-1"}},{"before":"5667ceaa1ef11833181407e1dd95d4765cdfa565","after":"e2242a95f3bb2e68ec0e9a064238ff7af6429545","ref":"refs/heads/main","pushedAt":"2023-10-13T14:56:49.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Merge pull request #5641 from henryaj/patch-1\n\nFix README anchor link","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1942115862\" data-permission-text=\"Title is private\" data-url=\"https://github.com/heartcombo/devise/issues/5641\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/heartcombo/devise/pull/5641/hovercard\" href=\"https://github.com/heartcombo/devise/pull/5641\">#5641</a> from henryaj/patch-1"}},{"before":"09b6b46ea4374f0204a12043038d0fb88af93f09","after":"d9eb3a50b91abee6c80095534d1c41c100e9162f","ref":"refs/heads/ca-mongoid","pushedAt":"2023-10-13T14:54:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Update dirty tracking to support Mongoid 8.0+\n\nIt appears Mongoid 8.0+ slightly [changed dirty tracking] behavior to\nmore closely match Active Model/Record, however they haven't yet\nintroduced the [new methods] that match the latest API, that seems to be\ncoming on Mongoid 8.1 only.\n\nThe changes here try to accommodate for that by determining which\n\"attribute_changed?\" method to call depending on whether the\n\"*_previously_*\" version exists. Newer versions of AR (5.1+) will\ncontinue to use the new API / methods, whereas previous versions and\nMongoid 8.0+ will use these tweaked versions. No behavior should change\nfor AR, but it will hopefully support Mongoid 8.0+ now.\n\n[changed dirty tracking]\nhttps://github.com/mongodb/mongoid/pull/5092\n\n[new methods]\nhttps://github.com/mongodb/mongoid/pull/5440","shortMessageHtmlLink":"Update dirty tracking to support Mongoid 8.0+"}},{"before":"63939c121e656075296808fd2627cab5a0352ba3","after":null,"ref":"refs/heads/rm-drop-support-to-old-rubies-and-rails","pushedAt":"2023-10-13T14:23:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"}},{"before":"4d18d8131109c5fd9099e7f2168b2bf6f7f68b7d","after":"5667ceaa1ef11833181407e1dd95d4765cdfa565","ref":"refs/heads/main","pushedAt":"2023-10-13T14:23:18.000Z","pushType":"pr_merge","commitsCount":7,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Merge pull request #5600 from heartcombo/rm-drop-support-to-old-rubies-and-rails\n\nDrop support to EOL rubies and Rails","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1750603853\" data-permission-text=\"Title is private\" data-url=\"https://github.com/heartcombo/devise/issues/5600\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/heartcombo/devise/pull/5600/hovercard\" href=\"https://github.com/heartcombo/devise/pull/5600\">#5600</a> from heartcombo/rm-drop-support-to-old-rubie…"}},{"before":"e688b2f2566685fb9355b4279ab2315f910b2eb4","after":"4d18d8131109c5fd9099e7f2168b2bf6f7f68b7d","ref":"refs/heads/main","pushedAt":"2023-10-13T14:20:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Respect locale set by controller in the failure app (#5567)\n\nA common usage of I18n with different locales is to create some around\ncallback in the application controller that sets the locale for the\nentire action, via params/url/user/etc., which ensure the locale is\nrespected for the duration of that action, and resets at the end.\n\nDevise was not respecting the locale when the authenticate failed and\ntriggered the failure app, because that happens in a warden middleware\nright up in the change, by that time the controller around callback had\nalready reset the locale back to its default, and the failure app would\njust translate flash messages using the default locale.\n\nNow we are passing the current locale down to the failure app via warden\noptions, and wrapping it with an around callback, which makes the\nfailure app respect the set I18n locale by the controller at the time\nthe authentication failure is triggered, working as expected. (much more\nlike a normal controller would.)\n\nI chose to introduce a callback in the failure app so we could wrap the\nwhole `respond` action processing rather than adding individual `locale`\noptions to the `I18n.t` calls, because that should ensure other possible\n`I18n.t` calls from overridden failure apps would respect the set locale\nas well, and makes it more like one would implement in a controller. I\ndon't recommend people using callbacks in their own failure apps though,\nas this is not going to be documented as a \"feature\" of failures apps,\nit's considered \"internal\" and could be refactored at any point.\n\nIt is possible to override the locale with the new `i18n_locale` method,\nwhich simply defaults to the passed locale from the controller.\n\nCloses #5247\nCloses #5246\n\nRelated to: #3052, #4823, and possible others already closed.\nRelated to warden: (may be closed there afterwards)\nhttps://github.com/wardencommunity/warden/issues/180\nhttps://github.com/wardencommunity/warden/issues/170","shortMessageHtmlLink":"Respect locale set by controller in the failure app (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1612436511\" data-permission-text=\"Title is private\" data-url=\"https://github.com/heartcombo/devise/issues/5567\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/heartcombo/devise/pull/5567/hovercard\" href=\"https://github.com/heartcombo/devise/pull/5567\">#5567</a>)"}},{"before":"50af639d3085b5275f69cf041e31118b08f8e037","after":null,"ref":"refs/heads/ca-fix-i18n-locale-failure-app","pushedAt":"2023-10-13T14:19:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"}},{"before":"1d6658097e364d45b5e059976f1e822eee7d67da","after":"edffc79bf05d7f1c58ba50ffeda645e2e4ae0cb1","ref":"refs/heads/4-stable","pushedAt":"2023-10-13T14:19:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Respect locale set by controller in the failure app (#5567)\n\nA common usage of I18n with different locales is to create some around\r\ncallback in the application controller that sets the locale for the\r\nentire action, via params/url/user/etc., which ensure the locale is\r\nrespected for the duration of that action, and resets at the end.\r\n\r\nDevise was not respecting the locale when the authenticate failed and\r\ntriggered the failure app, because that happens in a warden middleware\r\nright up in the change, by that time the controller around callback had\r\nalready reset the locale back to its default, and the failure app would\r\njust translate flash messages using the default locale.\r\n\r\nNow we are passing the current locale down to the failure app via warden\r\noptions, and wrapping it with an around callback, which makes the\r\nfailure app respect the set I18n locale by the controller at the time\r\nthe authentication failure is triggered, working as expected. (much more\r\nlike a normal controller would.)\r\n\r\nI chose to introduce a callback in the failure app so we could wrap the\r\nwhole `respond` action processing rather than adding individual `locale`\r\noptions to the `I18n.t` calls, because that should ensure other possible\r\n`I18n.t` calls from overridden failure apps would respect the set locale\r\nas well, and makes it more like one would implement in a controller. I\r\ndon't recommend people using callbacks in their own failure apps though,\r\nas this is not going to be documented as a \"feature\" of failures apps,\r\nit's considered \"internal\" and could be refactored at any point.\r\n\r\nIt is possible to override the locale with the new `i18n_locale` method,\r\nwhich simply defaults to the passed locale from the controller.\r\n\r\nCloses #5247\r\nCloses #5246\r\n\r\nRelated to: #3052, #4823, and possible others already closed.\r\nRelated to warden: (may be closed there afterwards)\r\nhttps://github.com/wardencommunity/warden/issues/180\r\nhttps://github.com/wardencommunity/warden/issues/170","shortMessageHtmlLink":"Respect locale set by controller in the failure app (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1612436511\" data-permission-text=\"Title is private\" data-url=\"https://github.com/heartcombo/devise/issues/5567\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/heartcombo/devise/pull/5567/hovercard\" href=\"https://github.com/heartcombo/devise/pull/5567\">#5567</a>)"}},{"before":"68d048c54eee81a577957ba982121e00f44f1264","after":"50af639d3085b5275f69cf041e31118b08f8e037","ref":"refs/heads/ca-fix-i18n-locale-failure-app","pushedAt":"2023-10-13T14:06:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Respect locale set by controller in the failure app\n\nA common usage of I18n with different locales is to create some around\ncallback in the application controller that sets the locale for the\nentire action, via params/url/user/etc., which ensure the locale is\nrespected for the duration of that action, and resets at the end.\n\nDevise was not respecting the locale when the authenticate failed and\ntriggered the failure app, because that happens in a warden middleware\nright up in the change, by that time the controller around callback had\nalready reset the locale back to its default, and the failure app would\njust translate flash messages using the default locale.\n\nNow we are passing the current locale down to the failure app via warden\noptions, and wrapping it with an around callback, which makes the\nfailure app respect the set I18n locale by the controller at the time\nthe authentication failure is triggered, working as expected. (much more\nlike a normal controller would.)\n\nI chose to introduce a callback in the failure app so we could wrap the\nwhole `respond` action processing rather than adding individual `locale`\noptions to the `I18n.t` calls, because that should ensure other possible\n`I18n.t` calls from overridden failure apps would respect the set locale\nas well, and makes it more like one would implement in a controller. I\ndon't recommend people using callbacks in their own failure apps though,\nas this is not going to be documented as a \"feature\" of failures apps,\nit's considered \"internal\" and could be refactored at any point.\n\nIt is possible to override the locale with the new `i18n_locale` method,\nwhich simply defaults to the passed locale from the controller.\n\nCloses #5247\nCloses #5246\n\nRelated to: #3052, #4823, and possible others already closed.\nRelated to warden: (may be closed there afterwards)\nhttps://github.com/wardencommunity/warden/issues/180\nhttps://github.com/wardencommunity/warden/issues/170","shortMessageHtmlLink":"Respect locale set by controller in the failure app"}},{"before":"3481b9e58d0197a9479bc2cd0b64a71bd706d3fe","after":null,"ref":"refs/heads/ca/fix-tests","pushedAt":"2023-10-13T14:04:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"}},{"before":"72b421e571ac7e3316f51917b363f5525fea8fd7","after":"63939c121e656075296808fd2627cab5a0352ba3","ref":"refs/heads/rm-drop-support-to-old-rubies-and-rails","pushedAt":"2023-10-13T14:02:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Remove deprecated options argument from update methods\n\nThey were added to support an old/deprecated feature of Rails, as the\nmessage was saying, we can now remove them from the code as well.","shortMessageHtmlLink":"Remove deprecated options argument from update methods"}},{"before":"a2318976863e3503341b71b8c85c558d94dc3cd3","after":"72b421e571ac7e3316f51917b363f5525fea8fd7","ref":"refs/heads/rm-drop-support-to-old-rubies-and-rails","pushedAt":"2023-10-13T13:44:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"carlosantoniodasilva","name":"Carlos Antonio da Silva","path":"/carlosantoniodasilva","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26328?s=80&v=4"},"commit":{"message":"Update gemfile readme references","shortMessageHtmlLink":"Update gemfile readme references"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAELUJiOQA","startCursor":null,"endCursor":null}},"title":"Activity · heartcombo/devise"}