Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support StrictMode #93

Open
dimaqq opened this issue Apr 16, 2019 · 2 comments
Open

Support StrictMode #93

dimaqq opened this issue Apr 16, 2019 · 2 comments

Comments

@dimaqq
Copy link

dimaqq commented Apr 16, 2019

[xxx] Warning: Unsafe lifecycle methods were found within a strict-mode tree:
    in StrictMode (at [xxx])

componentWillMount: Please update the following components to use componentDidMount instead: t

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: t
@davidrenne
Copy link

I was getting thousands of errors in my console when I ran strict mode uncaught TypeError: (n.globalFilter || e.filter) is not a function, not so sure this library is ready for react 18

@davidrenne
Copy link

@dimaqq and other people searching for this problem, I got around this issue of logging like crazy by passing this as a prop to all my callers.

filter={(v) => { return v; }}
It seems like react is not honoring the defaultProps when in strict mode. I am not sure why, I did a google on it but couldnt find a definitive answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants