Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goals: Continuous integration and code review #24

Open
ellenhp opened this issue May 31, 2022 · 3 comments
Open

Goals: Continuous integration and code review #24

ellenhp opened this issue May 31, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@ellenhp
Copy link
Member

ellenhp commented May 31, 2022

It would be really nice to have continuous integration that clones the repo, builds it for a small city and at least does health checks for all the services we bring up. There's a lot of churn happening right now but when the dust settles that seems like a good goal.

I also want to do more code review. I've sworn off committing directly to main because it's clear that other people actually care about this project now, but just now with #23 I realized there isn't really anyone around to review anything except one person, and I don't want to shove all the review work onto one person. So if you want to help out with that leave a comment here!

@3nprob
Copy link
Contributor

3nprob commented Jun 1, 2022

Happy to do reviews, though I can't commit to consistently responding up in a timely manner

@ellenhp
Copy link
Member Author

ellenhp commented Jun 1, 2022

Mkay, I'm going to look at getting you added as a collaborator, but apparently a lot of the features I want (restricting both of our abilities to push directly to main, etc) are for organization accounts only so I might port the repo out of my personal account at some point to get those.

@ellenhp ellenhp added the enhancement New feature or request label Jun 2, 2022
@ellenhp
Copy link
Member Author

ellenhp commented Aug 15, 2022

We have CI! #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants