Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort out the keymap nonsense #6

Open
boneskull opened this issue Oct 28, 2022 · 1 comment
Open

sort out the keymap nonsense #6

boneskull opened this issue Oct 28, 2022 · 1 comment
Assignees

Comments

@boneskull
Copy link
Collaborator

So there are keys & keycodes that the remote understands and keys & keycodes that chomedriver understands.

Ideally, someone using the driver should be able to provide the same key/keycode regardless of how the key gets pressed.

But there isn't a 1:1 relationship, and the identifiers are not the same (whether that's because they really aren't, or because of how we've implemented).

So:

  1. Track down the list of what the remote understands
  2. Cross-reference it with what chromedriver understands
  3. Provide a unified, sane interface

This may cause breaking changes, but if we assume that the chromedriver strategy isn't actually being used (which may be a safe assumption), we can likely isolate the breakage to that subsystem.

I suspect that gathering the necessary information will be a combination of reading more LG dev docs and cruising GitHub for implementations.

@boneskull boneskull self-assigned this Oct 28, 2022
@jlipps
Copy link
Collaborator

jlipps commented Oct 28, 2022

yeah this is a good idea. luckily i don't think we'd be breaking this for any serious use yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants