Add Shingle and ShingleSlidingWindow #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! |
test: update unit tests for Cosine/Jaccard with shingle
|
Hi @ShriprajwalK ! |
|
Yeah, looks good to me! |
|
It's merged 🎉 |
hbollon
added a commit
that referenced
this pull request
Nov 21, 2021
* feat: add Shingle function * test: update unit tests for Cosine/Jaccard with shingle Co-authored-by: Shriprajwal K <the_daemon_lord@Shriprajwals-MacBook-Air.local> Co-authored-by: hbollon <hugo.bollon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Added two methods, one that slices length n each time and the other uses sliding window. The first one was slightly faster for all values I checked, so I think we should remove the sliding window method.
Sorry for the delay, I wanted to benchmark them both properly but couldn't find the time.