builder.objectRef incorrect types in deno

[jnssnmrcs]

I'm trying to use pothos in deno and have the following issue:

export const AuthPayloadObject = builder.objectRef<AuthPayload>("AuthPayload");

results in AuthPayloadObject being of type:

ImplementableObjectRef<Types, T>

It's like typescript does not assign the correct type to the generic, which prevents me from calling any functions at all, for example .implement. How can I fix this issue?

[hayes]

This looks like a bug was introduced in esm.sh. For example, if you open up https://esm.sh/v126/@pothos/core@3.23.1/X-ZS8q/dts/builder.d.ts, you will see an import like:

import ObjectRef, { ImplementableObjectRef } from './refs/object';

This should be import ObjectRef, { ImplementableObjectRef } from './refs/object.d.ts';. It seems specific to imports that import both named exports and the default export, with imports like import UnionRef from './refs/union.d.ts'; being converted correctly

[jnssnmrcs]

Alright thanks, will try that instead.

[jnssnmrcs]

Getting correct intellisense types now but getting the following error when starting:

error: Uncaught PothosError: No plugin named errors was registered
    at file:///C:/Users/marcu/AppData/Local/deno/npm/registry.npmjs.org/@pothos/core/3.29.0/esm/build-cache.js:506:23
    at Array.map (<anonymous>)
    at new BuildCache (file:///C:/Users/marcu/AppData/Local/deno/npm/registry.npmjs.org/@pothos/core/3.29.0/esm/build-cache.js:503:162)   
    at SchemaBuilder.toSchema (file:///C:/Users/marcu/AppData/Local/deno/npm/registry.npmjs.org/@pothos/core/3.29.0/esm/builder.js:329:28)
    at file:///C:/Users/marcu/projects/cookbook-deno/src/schema/index.ts:8:31

Import map:

{
  "imports": {
    "std/": "https://deno.land/std@0.187.0/",
    "zod": "https://deno.land/x/zod@v3.21.4/mod.ts",
    "jwt": "https://raw.githubusercontent.com/jnssnmrcs/jwt/1.0.1/mod.ts",
    "pentagon": "https://deno.land/x/pentagon@v0.1.1/mod.ts",
    "graphql": "npm:graphql@16.6.0",
    "graphql-yoga": "npm:graphql-yoga@3.8.0",
    "@pothos/core": "npm:@pothos/core@3.29.0",
    "@pothos/plugin-errors": "npm:@pothos/plugin-errors@3.11.0",
    "@pothos/plugin-scope-auth": "npm:@pothos/plugin-scope-auth@3.19.0"
  }
}

builder:

import SchemaBuilder from "@pothos/core";
import ScopeAuthPlugin from "@pothos/plugin-scope-auth";
import ErrorsPlugin from "@pothos/plugin-errors";
import { GraphQLError } from "graphql";
import DateTimeResolver from "./scalars/date-time.ts";
import { AuthenticatedContext, Context } from "./context.ts";

export const builder = new SchemaBuilder<{
  Scalars: {
    DateTime: {
      Input: Date;
      Output: Date;
    };
  };
  Context: Context;
  AuthScopes: {
    loggedIn: boolean;
    admin: boolean;
  };
  AuthContexts: {
    loggedIn: AuthenticatedContext;
    admin: AuthenticatedContext;
  };
}>({
  plugins: [ErrorsPlugin, ScopeAuthPlugin],
  authScopes: (context) => ({
    loggedIn: !!context.user,
    admin: context.user?.role === "ADMIN",
  }),
  scopeAuthOptions: {
    authorizeOnSubscribe: true,
    treatErrorsAsUnauthorized: false,
    unauthorizedError: () =>
      new GraphQLError("Unauthorized", {
        extensions: {
          code: "UNAUTHORIZED",
        },
      }),
  },
  errorOptions: {
    defaultResultOptions: {
      name: ({ fieldName }) => `${fieldName}Success`,
    },
    defaultUnionOptions: {
      name: ({ fieldName }) => `${fieldName}Result`,
    },
  },
});

builder.scalarType("DateTime", DateTimeResolver);

[hayes]

Currently this works for me:

import SchemaBuilder from "https://deno.land/x/pothos@release-1687998954/packages/core/mod.ts";
import ScopeAuthPlugin from "https://deno.land/x/pothos@release-1687998954/packages/plugin-scope-auth/mod.ts";
import ErrorsPlugin from "https://deno.land/x/pothos@release-1687998954/packages/plugin-errors/mod.ts";
import { GraphQLError, printSchema } from "graphql";
import {createYoga } from "graphql-yoga"
import { serve } from 'https://deno.land/std@0.157.0/http/server.ts'

export interface Context {
  req: unknown
  user?: {
      role: string
  }
}

export interface AuthenticatedContext extends Context {
  user: {
      role: string
  }
}

export const builder = new SchemaBuilder<{
  Scalars: {
    DateTime: {
      Input: Date;
      Output: Date;
    };
  };
  Context: Context;
  AuthScopes: {
    loggedIn: boolean;
    admin: boolean;
  };
  AuthContexts: {
    loggedIn: AuthenticatedContext;
    admin: AuthenticatedContext;
  };
}>({
  plugins: [ErrorsPlugin, ScopeAuthPlugin],
  authScopes: (context) => ({
    loggedIn: !!context.user,
    admin: context.user?.role === "ADMIN",
  }),
  scopeAuthOptions: {
    authorizeOnSubscribe: true,
    treatErrorsAsUnauthorized: false,
    unauthorizedError: () =>
      new GraphQLError("Unauthorized", {
        extensions: {
          code: "UNAUTHORIZED",
        },
      }),
  },
  errorOptions: {
    defaultResultOptions: {
      name: ({ fieldName }) => `${fieldName}Success`,
    },
    defaultUnionOptions: {
      name: ({ fieldName }) => `${fieldName}Result`,
    },
  },
});

builder.scalarType("DateTime", {
  serialize: (date) => date.toISOString(),
  parseValue: (value) => new Date(value as string),
});

builder.queryType({
  fields: (t) => ({
    hello: t.string({
      resolve: () => "world",
    }),
  })
})


console.log(printSchema(builder.toSchema()));

const yoga  = createYoga({
  schema: builder.toSchema(),
  context: () => ({})
})

serve(yoga, {
  onListen({ hostname, port }) {
    console.log(
      `Listening on http://${hostname}:${port}${yoga.graphqlEndpoint}`
    )
  }
})

with a deno config like:

{
  "imports": {
    "std/": "https://deno.land/std@0.187.0/",
    "zod": "https://deno.land/x/zod@v3.21.4/mod.ts",
    "jwt": "https://raw.githubusercontent.com/jnssnmrcs/jwt/1.0.1/mod.ts",
    "pentagon": "https://deno.land/x/pentagon@v0.1.1/mod.ts",
    "graphql": "npm:graphql@16.6.0",
    "https://cdn.skypack.dev/graphql?dts": "npm:graphql@16.6.0",
    "graphql-yoga": "npm:graphql-yoga@3.8.0",
    "@pothos/core": "https://deno.land/x/pothos/packages/core/mod.ts",
    "@pothos/plugin-errors": "https://deno.land/x/pothos/packages/plugin-errors/mod.ts",
    "@pothos/plugin-scope-auth": "https://deno.land/x/pothos/packages/plugin-scope-auth/mod.ts",
  }
}

But after a little testing, this is very flaky because of the way denos npm specifiers work. The issue is that there is no equivalent of "resolutions" from yarn/pnpm with the npm specifiers in deno. It looks like import maps aren't applied to imports inside an npm package, so you end up with multiple versions of pothos and graphql if any versions get out of sync, or have a mismatch in their dependency versions.

I think you can work around this by using something like pnpm to install the packages into a node_modules directly and using denos node-modules-dir flag, but not sure if that is the kind of solution you are looking for. I may also look into just fixing esm.sh so it can compile pothos correctly

[hayes]

Fix for esm.sh here: esm-dev/esm.sh#675

Hopefully.that should make the documented solution work again

[jnssnmrcs]

works now with documented solution :)