Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show map with location above the Get Directions link in the booking modal #141

Open
olafwrieden opened this issue Sep 11, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@olafwrieden
Copy link
Member

As a user, I'd like to see the location of the vaccination location on a map in the modal (above Get Directions) so that I can easily find the location.

Some ideas

  • iFrame map render with Mapbox
  • Pained path from current location to destination
  • Open to ideas
@olafwrieden olafwrieden added the enhancement New feature or request label Sep 11, 2021
@nzjs
Copy link

nzjs commented Sep 21, 2021

Mapbox GL would be a good option as they are actively supporting COVID-19 related applications, both financially and with technical support. You could also use their Directions API to display a route from the current location to selected destination.

Another option for a mapping library would be ArcGIS JS API, as they are also supporting COVID-19 applications with no-cost services.

@noway
Copy link
Member

noway commented Sep 23, 2021

@nzjs that's awesome! We're already using Google Maps iframe embed here though (https://vaxx.nz/locations/the-auckland-city-doctors-2076593017), that one is actually free. If we just do the map without directions, that would be an easier solution!

Would love for you take on that task and tackle it :-)

@nzjs
Copy link

nzjs commented Sep 28, 2021

@noway Sure I can take a look at this, I hadn't noticed that embed. Is the Google API costing anything right now?

So to clarify, you would like the current G Maps iframe replaced with one of the other mapping APIs as a component.
Referring to this: https://github.com/CovidEngine/vaxxnz/blob/main/src/today-locations/healthpoint/HealthpointModal.tsx#L200-L209

Or are we talking about adding a new small map component near the Get Directions link, in this modal?

snip

@noway
Copy link
Member

noway commented Sep 28, 2021

Yeah, adding a small map there. It does mean we'll have a lot of small maps on that page @waltzaround is that a good idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants