Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing the websocket-client-simple gem with the same gem that is being used in the MiQ #201

Open
jkremser opened this issue Mar 21, 2017 · 1 comment

Comments

@jkremser
Copy link
Member

jkremser commented Mar 21, 2017

When we added this dependency, the MiQ didn't have the support for websocket communication, they add it with migration to rails 5 (iirc). Since the websocket-client-simple is no longer maintained and it has other issues like failing non-deterministically on segfaults (https://travis-ci.org/hawkular/hawkular-client-ruby/jobs/213159442#L438). Also there is currently no way to process incoming binary websocket frames (also failing with segfaults), so that we can't implement the JDR reports in the middleware provider.

@rubenvp8510 rubenvp8510 self-assigned this Mar 21, 2017
@josejulio
Copy link
Member

I agree those segfaults are a killer and really frequent. I have to restart tests almost always on PRs and even on master branch after merge.

If that lib is compatible with ruby targets for this gem I would say we should do it 👍

@rubenvp8510 rubenvp8510 removed their assignment May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants