Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Softmax layer and residual connections in DeepHitSingle model #169

Open
Anivader opened this issue Aug 16, 2023 · 1 comment
Open

Softmax layer and residual connections in DeepHitSingle model #169

Anivader opened this issue Aug 16, 2023 · 1 comment

Comments

@Anivader
Copy link

Hi,

I am following this DeepHit tutorial for a single event - https://github.com/havakv/pycox/blob/master/examples/deephit.ipynb

In the model architecture, the "MLPVanilla" class inserts 2 hidden, linear layers. It seems like you don't have a "Softmax" layer at the end to obtain the survival probability distribution. Is this because it is already included in the loss function or do we not need to use it at all ?

net = tt.practical.MLPVanilla(in_features, num_nodes, out_features, batch_norm, dropout)
model = DeepHitSingle(net, tt.optim.Adam, alpha=0.2, sigma=0.1, duration_index=labtrans.cuts)

Also, it seems like you are not implementing "residual connections " as mentioned in the DeepHit paper. Could you please explain the reason for this ?

Thanks
Ani

@shahidhaider-altis
Copy link

You can use whatever pytorch network you want and use that for your net variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants