Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduction of the results in JMLR19 paper #164

Open
minxueric opened this issue May 10, 2023 · 1 comment
Open

Reproduction of the results in JMLR19 paper #164

minxueric opened this issue May 10, 2023 · 1 comment

Comments

@minxueric
Copy link

minxueric commented May 10, 2023

I find the results in the examples notebook are quite different from the results shown in your JMLR2019 paper.

For example, the Cox-time method on the metabric dataset:
in paper: Concordance=0.662, Integrated Brier score=0.172(best), Integrated binomial log-likelihood=-0.511
in notebook: Concordance=0.675, Integrated Brier score=0.159, Integrated binomial log-likelihood=-0.470

Could you please explain the difference and give the experiment code for reproduction of the results in the paper?

@havakv
Copy link
Owner

havakv commented May 16, 2023

The examples here are just examples with rather arbitrary hyperparameters. In the paper we have a common hyperparameter tuning strategy all methods we compare, to make the comparison fair (it's very easy to overtfit to such small datasets by just trying some configurations by hand). This is listed in section 6.1.1 of the paper. If you want to reproduce the results, you would need to follow the experiments as explained there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants