Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from socket.io to SSE / EventSource based EventStreams #31

Open
ottomata opened this issue Mar 21, 2017 · 2 comments
Open

Migrate from socket.io to SSE / EventSource based EventStreams #31

ottomata opened this issue Mar 21, 2017 · 2 comments

Comments

@ottomata
Copy link

As yall know, we are planning to decomission the socket.io based RCStream service in July this year. We've built a new service called EventStreams that takes its place.

Switching should be pretty easy, but let me know if we can help in any way. Thanks!

@slaporte
Copy link
Member

slaporte commented Mar 21, 2017

We're actually using wikimon to subscribe to the IRC feed, adding some geo coordinates for anons (based on their IP address) and some structure, and then rebroadcasting over websockets. I like using the IRC feed because it's stable and simple -- it's been running fine since before the Socket.io service.

My main questions about the SSE service are: is it guaranteed to be supported over the long term? does it capture identical data about recent changes events (like flags, change size, etc), or more? is there any plan to enrich the SSE stream further (eg, adding geo coords)?

@ottomata
Copy link
Author

Oh! Didn't realize you were using your own websockets broadcast. Hm. In that case you can probably decline this issue. We are probably stuck with irc.wikimedia.org for the time being, and don't have any plan to turn it off.

is it guaranteed to be supported over the long term?

Yes, as much as I can guarantee it (which maybe isn't enough?).

does it capture identical data about recent changes events

I don't know much about the IRCFeed events, but the data in EventStreams at /v2/stream/recentchange should be identical to RCStream data.

is there any plan to enrich the SSE stream further (eg, adding geo coords)?

I don't think we'll modify the recentchange data. But, EventStreams does have the ability to expose more events than just recenchanges, and we have more process over how those events are created and evolved. If there are events or data you want that isn't satisfied by recentchanges, we want to hear about them! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants