Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: failing web hook cache making requests timeout #10197

Open
meetzaveri opened this issue Apr 8, 2024 · 0 comments
Open

server: failing web hook cache making requests timeout #10197

meetzaveri opened this issue Apr 8, 2024 · 0 comments
Labels
k/bug Something isn't working

Comments

@meetzaveri
Copy link
Member

Version Information

Server Version: 2.37.0

Environment

EE

What is the current behaviour?

Currently, we have an issue where Redis connections can end up “dead” and just fail to return any data given some TLS settings

This manifests in very slow lookups to the auth hook cache. This is in context to webhook auth caching feature.

What is the expected behaviour?

The fix is to add a configurable timeout for Redis operations - if any operation takes over this time, we should close the connection and consider the operation failed (falling back to either the actual auth hook, or the actual request, whichever makes suitable fallback option at this time)

Keywords

redis webhook auth caching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant