Idempotent Insert / Upsert _PLACEHOLDER Error

[kevinmichaelchen]

Context

Hasura v2.29.0 recently released a new beta feature, Input Validation, which can allow a webhook to verify data payloads before they get inserted into the database.

The following bug only occurs when using an x-hasura-role that has been configured for remote Input Validation; when I'm just using the admin secret key, the request succeeds.

Minimal Reproduction

https://github.com/kevinmichaelchen/hasura-9767

Description

In my example, I have two Postgres tables: pet and owner.

Both have id uuid columns for primary keys.

There's a nullable owner_id column in the pet table.

When I perform a bulk insert using onConflict (basically an upsert), I get an error related to _PLACEHOLDER.

The Mutation

mutation CreatePetAndOwner(
  $owner: OwnerInsertInput!
  $pet: PetInsertInput!
) {
  owner: insertOwnerOne(
    object: $owner
    onConflict: {
      constraint: owner_pkey
      updateColumns: [id]
    }
  ) {
    id
  }
  
  pet: insertPetOne(
    object: $pet
    onConflict: {
      constraint: pet_pkey
      updateColumns: [id]
    }
  ) {
    id
  }
}

Variables

{
  "owner": {
    "id": "6b683c4d-0fb0-4f47-b3f4-822177753b1d",
    "name": "Kevin"
  },
  "pet": {
    "id": "5cd3dc17-1b05-433c-b8a4-9c2f4a09c603",
    "name": "Sparky",
    "ownerId": "6b683c4d-0fb0-4f47-b3f4-822177753b1d"
  }
}

Error Response

{
  "errors": [
    {
      "message": "expected one of the values ['_PLACEHOLDER'] for type 'OwnerUpdateColumn', but found 'id'",
      "extensions": {
        "path": "$.selectionSet.insertOwnerOne.args.onConflict.updateColumns[0]",
        "code": "validation-failed"
      }
    }
  ]
}

Getting it working

When I uncheck the x-hasura-role header and just use the admin secret (which involves no remote validation), the call succeeds as expected.

[kevinmichaelchen]

It was a Permissions issue all along.

I was just missing update permissions on those tables, so the upsert was failing. Per the docs:

Only tables with update permissions are upsertable. i.e. a table's update permissions are respected before updating an existing row in case of a conflict.

Fixed in this PR.

Thanks to @dventimihasura for spotting the fix.