Adds CSS Linter and Formatter #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the config. It would be great to do this through Nix rather than installing NPM separately. I might give it a try myself, but don't have the time/attention at the moment. In the meantime, please feel free to give it a go yourself if you're interested in learning! |
|
Looks like this will need some Nix work to be useful, and I probably won't get around to it any time soon. Going to close the PR for now, and we can always pick it up again later if we want linting/minimization for our CSS in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR is added a CSS Linter and Formatter to the project and created a step to verify the CSS on new Pull Requests.
I've added the Node.js environment to the action because I have no familiarity with Nix environments, so I'm open to change that according to any given suggestions.
To run that locally it's needed to have Node.js installed and run the following command inside the root directory:
$ npx stylelint 'css/*.css' --fixcloses #110