Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove insenstive language like "blacklist", "whitelist", "master", and "slave" #266

Open
rberlind opened this issue Jun 29, 2020 · 0 comments

Comments

@rberlind
Copy link
Contributor

There are no references to "blacklist".

We'll want to rename https://github.com/hashicorp/vault-guides/blob/master/governance/sentinel/egp-okta-user-whitelist.sentinel to egp-okta-user-allowlist.sentinel and change reference to it in https://github.com/hashicorp/vault-guides/blob/master/governance/sentinel/README.md to remove "whitelist".

We'll want to change variable names in https://github.com/hashicorp/vault-guides/blob/master/secrets/spring-cloud-vault/kubernetes/terraform/variables.tf and their use in https://github.com/hashicorp/vault-guides/blob/master/secrets/spring-cloud-vault/kubernetes/terraform/main.tf to remove "master"

If possible, make changes in https://github.com/hashicorp/vault-guides/blob/master/shared/vault/scripts/vault-k8s-helm.sh to remove "master"

"master" is used in https://github.com/hashicorp/vault-guides/blob/master/identity/vault-agent-k8s-demo/terraform-gcp/main.tf, but this is because that is what the Terraform google_container_cluster resource uses.

remove "master" from https://github.com/hashicorp/vault-guides/blob/master/identity/vault-agent-k8s-demo/terraform-gcp/README.md which refers to "Kubernetes master". It is in a comment, so could be removed.

https://github.com/hashicorp/vault-guides/blob/master/operations/raft-storage/aws/main.tf refers to "master key" but only in a comment, so it could be removed.

https://github.com/hashicorp/vault-guides/blob/master/operations/aws-kms-unseal-ha/terraform/README.md and https://github.com/hashicorp/vault-guides/blob/master/governance/audit/README.md refer to Vault's "master key" in text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant