Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.5 fails to build #615

Open
swills opened this issue Oct 9, 2020 · 2 comments
Open

0.9.5 fails to build #615

swills opened this issue Oct 9, 2020 · 2 comments

Comments

@swills
Copy link

swills commented Oct 9, 2020

When I try to build 0.9.5, I get:

go: inconsistent vendoring in /wrkdirs/usr/ports/sysutils/serf/work/serf-0.9.5:
        github.com/armon/go-radix@v1.0.0: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/armon/go-radix@v0.0.0-20180808171621-7fddfc383310
        github.com/fatih/color@v1.9.0: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/fatih/color@v1.7.0
        github.com/hashicorp/go-multierror@v1.1.0: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/hashicorp/go-multierror@v1.0.0
        github.com/hashicorp/memberlist@v0.2.2: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/hashicorp/memberlist@v0.2.0
        github.com/mattn/go-colorable@v0.1.6: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/mattn/go-colorable@v0.0.9
        github.com/mitchellh/cli@v1.1.0: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/mitchellh/cli@v1.0.0
        github.com/posener/complete@v1.2.3: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/posener/complete@v1.1.1

Am I doing something wrong? Let me know if more info is needed.

@swills
Copy link
Author

swills commented Oct 26, 2020

Perhaps I should note that I'm using -mod=vendor. You can reproduce the issue by adding -mod=vendor to scripts/build.sh in the args to gox. I think the fix is to run go mod vendor and commit the changes this produces.

@swills
Copy link
Author

swills commented Oct 26, 2020

I also noticed v0.9.5 calls itself 0.8.2-dev, serf -version includes:

0.8.2-dev (7faa1b06262f70780c3c35ac25a4c96d754f06f3)

I think due to:

https://github.com/hashicorp/serf/blob/v0.9.5/version/version.go#L16

and there are no binaries up for 0.9.5 at https://www.serf.io/downloads.html so perhaps this isn't a real release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant