Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generated document example has invalid "example-value" #3936

Open
ms-henglu opened this issue Mar 11, 2024 · 0 comments · May be fixed by #3937
Open

The generated document example has invalid "example-value" #3936

ms-henglu opened this issue Mar 11, 2024 · 0 comments · May be fixed by #3937

Comments

@ms-henglu
Copy link
Collaborator

In this example: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_fleet_member#example-usage,

resource "azurerm_kubernetes_cluster" "example" {
  name                = "example"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  dns_prefix          = "acctestaksexample"
  default_node_pool {
    name       = "example-value"
    node_count = "example-value"
    vm_size    = "example-value"
  }
  identity {
    type = "example-value"
  }
}

The node_count's example value is invalid, it should be a number, but a string.

The codes related: https://github.com/hashicorp/pandora/blob/main/tools/importer-rest-api-specs/components/terraform/examples/variable_replacements.go#L78

Can we update this to keep the values as in the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant