Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isotime function works in an unusual/confusing/insane way and reflects poorly on the project #6278

Closed
paulcdejean opened this issue May 16, 2018 · 3 comments
Labels
core Core components of Packer enhancement need-more-info wontfix Out of scope/alignment with the project, or issue is expected, intended behavior

Comments

@paulcdejean
Copy link

https://www.packer.io/docs/templates/engine.html#isotime-function-format-reference

This sort of thing is so obviously nutty, that it makes people second guess relying on packer.

I understand that this can't be changed in a backwards incompatible way, but a more sensible replacement should be created, so that this can be depreciated.

This is more of a public relations issue than anything. The current function probably works maybe, but it's still r/softwaregore material.

@rickard-von-essen
Copy link
Collaborator

It can be good to back up your claims with some facts/example. It does work, and just passas the parameters to Go's std lib function for formatting time dates.

@SwampDragons
Copy link
Contributor

Hi, @paulcdejean. Thanks for letting us know that you find this feature unintuitive. However, if you're making a feature request, it's a good idea to give as much detail as possible. You've made it very clear that you don't like the current method of handling ISO timestamps, but "it's nutty" is not an actionable piece of feedback. What do you think, specifically, is nutty? The default? The way that the template manages the formatting strings? Packer also supports the template variable {{ timestamp }} which will give you the Unix (Epoch) time if you would prefer something simple that doesn't need formatting.

I'd also like to recommend that you take a look at our community guidelines: https://www.hashicorp.com/community-guidelines

I have a suspicion that this ticket was opened in a bout of frustration, which happens to all of us. But since it isn't actionable I am going to close it for now. If you have concrete suggestions about how to improve the tool, I'd be thrilled to hear them. Thanks!

@SwampDragons SwampDragons added enhancement wontfix Out of scope/alignment with the project, or issue is expected, intended behavior core Core components of Packer and removed stage/waiting-reply labels May 17, 2018
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Core components of Packer enhancement need-more-info wontfix Out of scope/alignment with the project, or issue is expected, intended behavior
Projects
None yet
Development

No branches or pull requests

3 participants