You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this is caused by a regression in the autoscaler API:
The plugin calls IdentifyScaleInNodes(config, int(count)). I looked at the current method definition and in the latest release and the second argument called num is unused. Previously, it would be read by a loop that selects num nodes to be destroyed from the list of live nodes, now it returns the whole array of live nodes instead.
I'm reporting this here because the method RunPreScaleInTasks is annotated with a comment that says COMPAT(0.4), I assume that you're trying to be backwards-compatible and that this was not an intentional change.
The text was updated successfully, but these errors were encountered:
I'm using the nomad-hcloud-autoscaler plugin by @AndrewChubatiuk (thank you for publishing it!). I noticed that it tries to drain & destroy all nodes on scale in.
I think this is caused by a regression in the autoscaler API:
The plugin calls
IdentifyScaleInNodes(config, int(count))
. I looked at the current method definition and in the latest release and the second argument callednum
is unused. Previously, it would be read by a loop that selectsnum
nodes to be destroyed from the list of live nodes, now it returns the whole array of live nodes instead.I'm reporting this here because the method RunPreScaleInTasks is annotated with a comment that says
COMPAT(0.4)
, I assume that you're trying to be backwards-compatible and that this was not an intentional change.The text was updated successfully, but these errors were encountered: