Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levant Deployment Service Deployment: Update Stanza #145

Open
stack72 opened this issue Apr 20, 2018 · 2 comments · May be fixed by #316 or #355
Open

Levant Deployment Service Deployment: Update Stanza #145

stack72 opened this issue Apr 20, 2018 · 2 comments · May be fixed by #316 or #355
Labels
stage/accepted theme/deploy Relates to the deployment of jobs type/bug

Comments

@stack72
Copy link
Contributor

stack72 commented Apr 20, 2018

Currently, when a service deployment happens, levant assumes that the Job will have the update stanza assigned to it

I currently use a template that looks like this:

job "tsg-v1" {
  type = "service"
  datacenters = ["us-east-1a"]
  group "deployment" {

    constraint {
      distinct_hosts = true
    }

    constraint {
      operator = "="
      attribute = "${meta.role}"
      value = "api-server"
    }

    update {
      health_check = "task_states"
      max_parallel = 1
      stagger      = "10s"
    }

Notice that the update stanza is in the group, therefore, the levant deployment throws the following info message:

2018/04/20 12:48:05 UTC [INFO] levant/deploy: job tsg-v1 is not configured with update stanza, consider adding to use deployments

This is because of the following code in levant:

// If the service job doesn't have an update stanza, the job will not use
// Nomad deployments.
if l.config.Job.Update == nil {
logging.Info("levant/deploy: job %s is not configured with update stanza, consider adding to use deployments", *l.config.Job.Name)
return l.jobStatusChecker(&eval.EvalID)
}


Would you be happy to check for a group update stanza here as well?
@jrasell jrasell added the bug label Apr 20, 2018
@jrasell
Copy link
Member

jrasell commented Apr 20, 2018

hey @stack72 thanks for the issue and you're exactly right that the update stanza should be checked at both the job and group level; sorry about that.

@stack72
Copy link
Contributor Author

stack72 commented Apr 20, 2018

@jrasell sending a PR right now :)

@Mongey Mongey linked a pull request Dec 2, 2019 that will close this issue
@jrasell jrasell added stage/accepted theme/deploy Relates to the deployment of jobs type/bug and removed bug labels Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/accepted theme/deploy Relates to the deployment of jobs type/bug
Projects
None yet
2 participants