Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring using Prometheus #1338

Open
fischerman opened this issue Feb 5, 2020 · 2 comments · Fixed by #1378
Open

Monitoring using Prometheus #1338

fischerman opened this issue Feb 5, 2020 · 2 comments · Fixed by #1378
Assignees

Comments

@fischerman
Copy link

fischerman commented Feb 5, 2020

This is related to monitoring Consul Template. The discussion in #570 has converged to sending health data to Consul (issue has been stale since early 2018). I'm proposing to expose metrics using the Prometheus (soon OpenMetrics format)

Here are my thoughts:

  • Works well in Kubernetes settings. Prometheus is most common monitoring solution right now.
  • We are using Consul Template as a sidecar. Hence, there is no port conflict (which is one of the concerns by @sethvargo in #570). The http server could be disabled by default, to prevent breaking changes.
  • Consul Template can be used just for Vault, in which case there is no Consul to send data to.
  • Other HashiCorp products adapt Prometheus as well (e.g. see Prometheus support on v1/sys/metrics endpoint vault#5308)
@eikenb
Copy link
Contributor

eikenb commented Feb 6, 2020

Hey @fischerman, thanks for submitting this.

Going to pre-thank you for your patience as we make time to get to this issue. We will be super busy with an internal project for the next few weeks and won't be able to look at this until after that.

On the up side though the team for these projects is growing, currently there are 2 of us and we might be getting a 3rd person. So I'm hoping we will be able to not only pay more attention to incoming issues/enhancements but really catch up with all the backlog. Again let me convey my appreciation for taking the time to help and for your patience while we get caught up with everything.

@eikenb
Copy link
Contributor

eikenb commented Jul 23, 2020

Moving to go-metrics. See #1395.

@eikenb eikenb reopened this Jul 23, 2020
@eikenb eikenb removed this from the 0.26.0 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants