Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mirror Node e2e test coverage leveraging existing Mirror Node acceptance tests #148

Open
Tracked by #50
jeromy-cannon opened this issue Mar 7, 2024 · 0 comments
Open
Tracked by #50

Add Mirror Node e2e test coverage leveraging existing Mirror Node acceptance tests #148

jeromy-cannon opened this issue Mar 7, 2024 · 0 comments
Assignees
@jeromy-cannon
Labels
Improvement Code changes driven by non business requirements

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Mar 7, 2024 •
edited

An easy option is to pull tests from the mirror node acceptance tests.
We have a lot of coverage there from over the years, it uses the SDK to submit and then queries the mirror node endpoints.
I’m AFK so you might want to ping #mirror-node for someone to point you to some E2E tests you can easily copy for CI
Once that’s done the team can expand coverage later on to cover the relay

Slack thread: https://swirldslabs.slack.com/archives/C06FWU24B7Y/p1709227738903319?thread_ts=1709044001.965159&cid=C06FWU24B7Y
@jeromy-cannon jeromy-cannon mentioned this issue Mar 7, 2024
Open
@jeromy-cannon jeromy-cannon self-assigned this Mar 7, 2024
@jeromy-cannon jeromy-cannon added Improvement Code changes driven by non business requirements Needs Triage Further development work cannot be done labels Mar 7, 2024
@leninmehedy leninmehedy removed the Needs Triage Further development work cannot be done label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromy-cannon jeromy-cannon

Labels
Improvement Code changes driven by non business requirements
Projects
Solo
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leninmehedy @jeromy-cannon