Node: HAPI Test (Restart) Results

2 tests   2 ✅  7m 47s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 824d8b8.

♻️ This comment has been updated with latest results.

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  9m 3s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 824d8b8.

♻️ This comment has been updated with latest results.

Node: HAPI Test (Token) Results

235 tests   233 ✅  21m 1s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 824d8b8.

♻️ This comment has been updated with latest results.

Node: HAPI Test (Misc) Results

459 tests   448 ✅  43m 8s ⏱️
 77 suites   10 💤
 77 files      1 ❌

For more details on these failures, see this check.

Results for commit 824d8b8.

♻️ This comment has been updated with latest results.

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  39m 28s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 824d8b8.

♻️ This comment has been updated with latest results.

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 18s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 824d8b8.

♻️ This comment has been updated with latest results.

Node: Unit Test Results

  2 284 files  + 2    2 284 suites  +2   1h 58m 56s ⏱️ - 13m 38s
118 838 tests +10  118 771 ✅ +10  67 💤 ±0  0 ❌ ±0 
127 326 runs  +10  127 259 ✅ +10  67 💤 ±0  0 ❌ ±0 

Results for commit 824d8b8. ± Comparison against base commit ea76bda.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=Austin,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=16700,hostnameExternal=131.178.48.79,portExternalIpv4=7006,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@75e9ccfe,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@2911f7a,memo=7ph3eSAgG2],
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@bbce7d06
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@bb019d3
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@47ead9fb
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@9059326e
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@46b1bfc3
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@41cac30d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@1d1458f3
…

♻️ This comment has been updated with latest results.

Node: HAPI Test (Smart Contract) Results

592 tests   591 ✅  1h 6m 58s ⏱️
 63 suites    0 💤
 63 files      1 ❌

For more details on these failures, see this check.

Results for commit 824d8b8.

♻️ This comment has been updated with latest results.

Long ago when we designed the consensus engine, we agreed that it would detect stale event internally. It would be a simple change contained within 1 component. So why use this approach?

@lpetrovic05

Long ago when we designed the consensus engine, we agreed that it would detect stale event internally. It would be a simple change contained within 1 component. So why use this approach?

The problem I keep running into when I try to do this in the consensus engine is that it drastically increases the complexity of that component (adding new inputs, adding new outputs, etc.). In my mind, the overhead of keeping a stand alone hash map of non-ancient self events is justified by the separation of concerns and reduction in complexity of the consensus engine.