ci: updated for best practices #2260
Conversation
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
…and-standards Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2260 +/- ##
==========================================
+ Coverage 76.49% 84.26% +7.76%
==========================================
Files 304 53 -251
Lines 75800 11432 -64368
==========================================
- Hits 57986 9633 -48353
+ Misses 17814 1799 -16015 ☔ View full report in Codecov by Sentry. |
| # NOTE: Must be placed last to ensure enforcement over all other rules | ||
|
|
||
| # Protection Rules for Github Configuration Files and Actions Workflows | ||
| /.github/ @hashgraph/release-engineering @hashgraph/release-engineering-managers |
There was a problem hiding this comment.
why maintainers should not have access to .github folder?
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
.github/CODEOWNERS
Outdated
|
|
||
| # Protection Rules for Github Configuration Files and Actions Workflows | ||
| /.github/ @hashgraph/release-engineering @hashgraph/release-engineering-managers | ||
| /.github/workflows/ @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/hedera-sdk @hashgraph/hedera-sdk-js-contributors @SimiHunjan |
There was a problem hiding this comment.
@hashgraph/hedera-sdk-js-contributors in this group there are people who are not actively working on the JS SDK right now and on every new PR they are going to be spammed with emails.
- I think we should drop the contributors group.
- Second thing is in hedera-sdk only Robert is a member, and he is not working on the JS SDK.
- In my opinion we should have a group similar to
hedera-sdk-java-maintainersbuthedera-sdk-js-maintainersand in this group to be only the people working actively on the JS SDK right now, and only they to be receive emails for new PRs
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
|
Description:
Updating workflows as part of the CI audit on hashgraph org repos.
Related issue(s):
Fixes #2243
Notes for reviewer:
Checklist