Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Generic response code for invalid Key #197

Open
anighanta opened this issue May 6, 2022 · 0 comments · May be fixed by #198
Open

Add a Generic response code for invalid Key #197

anighanta opened this issue May 6, 2022 · 0 comments · May be fixed by #198
Assignees

Comments

@anighanta
Copy link
Contributor

anighanta commented May 6, 2022

Currently most of the keys [PauseKey, AdminKey, KycKey ..] have appropriate response codes.
But an Account's Key set during a cryptoCreate / cryptoUpdate doest have one and we are are reusing BAD_ENCODING as the response for this.

solution
Use response code INVALID_ADMIN_KEY to be more meaningful in the above case and add notes in HAPI that an Admin key on the account is it's key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants