Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional response codes for extending alias support #135

Merged
merged 4 commits into from Jan 20, 2022

Conversation

Neeharika-Sompalli
Copy link
Member

Closes #134

For extending alias support to all transactions and Queries, added additional response codes to be returned if account ID given is invalid or does not exist.

services/response_code.proto Show resolved Hide resolved
services/response_code.proto Show resolved Hide resolved
SimiHunjan
SimiHunjan previously approved these changes Jan 14, 2022
qnswirlds
qnswirlds previously approved these changes Jan 15, 2022
steven-sheehy
steven-sheehy previously approved these changes Jan 18, 2022
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinker-michaelj tinker-michaelj merged commit dff1949 into develop Jan 20, 2022
@tinker-michaelj tinker-michaelj deleted the HIP-32-0134-D-additionalResponseCodes branch January 20, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-32 Add additional response codes for extending alias support
5 participants