Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove retries on tests #2438

Open
Tracked by #2380
georgi-l95 opened this issue Apr 27, 2024 · 1 comment
Open
Tracked by #2380

Remove retries on tests #2438

georgi-l95 opened this issue Apr 27, 2024 · 1 comment
Assignees
@yaroslav-007
Labels
blocked This is blocked by another item limechain

Comments

@georgi-l95
Copy link
Collaborator

georgi-l95 commented Apr 27, 2024 •
edited

Having retries on tests is anti-pattern, because they usually never succeed if they fail once. This adds additional unneccessery time to the CI runners.
@georgi-l95 georgi-l95 mentioned this issue Apr 27, 2024
Open
@georgi-l95 georgi-l95 added limechain blocked This is blocked by another item labels Apr 27, 2024
@yaroslav-007 yaroslav-007 self-assigned this Apr 30, 2024
@AlfredoG87
Copy link
Collaborator

Having retries on tests is anti-pattern, because they usually never succeed if they fail once. This adds additional unneccessery time to the CI runners.

there are some cases where they succed, those were it depends drom the mirror node sync on records

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaroslav-007 yaroslav-007

Labels
blocked This is blocked by another item limechain
Projects
Smart Contract Sprint Board
Status: Sprint Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@georgi-l95 @yaroslav-007 @AlfredoG87