Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove networkTag:0.49.1 input in API_Batch1 and ws_batch2 CI tasks #2402

Closed
quiet-node opened this issue Apr 24, 2024 · 0 comments · Fixed by #2427
Closed

Remove networkTag:0.49.1 input in API_Batch1 and ws_batch2 CI tasks #2402

quiet-node opened this issue Apr 24, 2024 · 0 comments · Fixed by #2427
Assignees
@quiet-node
Labels
enhancement New feature or request

Comments

@quiet-node
Copy link
Collaborator

Problem

Currently, ABI Batch 1 and Websocket Batch 2 AI tasks are configured with networkTag:0.49.1 to facilitate the execution of deterministic proxy contract deployment transactions as detailed in PR#2393. This adjustment is necessary due to the limitation of hedera-local@0.22.0, which exclusively supports NETWORK_NODE_IMAGE_TAG at 0.49.0-alpha.3.

Solution

Once hedera-local extends support to NETWORK_NODE_IMAGE_TAG version 0.49.1 or higher, the hardcoded networkTag:0.49.1 in the specified CIs should be removed.

Alternatives

No response
@quiet-node quiet-node added the enhancement New feature or request label Apr 24, 2024
@quiet-node quiet-node self-assigned this Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Merged
Merged
@quiet-node quiet-node linked a pull request Apr 26, 2024 that will close this issue
ci: removed networkTag for API Batch 1 and Websocket Batch 2 CI tasks (#2402) #2427
Merged
2 tasks
quiet-node added a commit that referenced this issue Apr 29, 2024
@quiet-node
ci: removed networkTag for API Batch 1 and Websocket Batch 2 CI tasks (…
98894e8 
…#2402) (#2427)

CI: removed networkTag for API Batch 1 and Websocket Batch 2 CI tasks

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quiet-node quiet-node

Labels
enhancement New feature or request
Projects
Smart Contract Sprint Board
Status: Done
Milestone
No milestone
1 participant
@quiet-node