Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return types to subscriptionController file #2307

Open
konstantinabl opened this issue Apr 9, 2024 · 3 comments
Open

Add return types to subscriptionController file #2307

konstantinabl opened this issue Apr 9, 2024 · 3 comments
Labels
enhancement New feature or request limechain

Comments

@konstantinabl
Copy link
Collaborator

Problem

Return types for some functions in the subscriptionController file are missing

Solution

Add return types, where needed

Alternatives

No response

@konstantinabl konstantinabl added enhancement New feature or request limechain labels Apr 9, 2024
@quiet-node
Copy link
Collaborator

quiet-node commented Apr 15, 2024

Could you please give me a little more context on this issue?

@konstantinabl
Copy link
Collaborator Author

konstantinabl commented Apr 15, 2024

@quiet-node
For example function below has no return type:
Screenshot 2024-04-15 at 16 41 58

Should be like this:
Screenshot 2024-04-15 at 16 42 48

Thats a good practice and it actually makes sense, since this is one of the reasons why typescript is used

@quiet-node
Copy link
Collaborator

Ah I see! Yes indeed that's a good practice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain
Projects
None yet
Development

No branches or pull requests

2 participants