Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design fixes: header #153

Open
niryariv opened this issue Dec 7, 2020 · 3 comments
Open

design fixes: header #153

niryariv opened this issue Dec 7, 2020 · 3 comments
Assignees
@niryariv
Projects
datacity

Comments

@niryariv
Copy link

niryariv commented Dec 7, 2020

  1. navbar links should be centered

  2. data city logo should appear on the right/left (according to user settings). For now the logo should not be link

current:
Screen Shot 2020-12-07 at 14 15 58

goal:
Screen Shot 2020-12-07 at 14 16 12
@niryariv niryariv added this to High Priority in datacity Dec 7, 2020
@OriHoch
Copy link
Contributor

OriHoch commented Dec 7, 2020

datacity logo should be set from the settings page (datacity logo URL)

you can copy from maale adummim - https://maale-adummim.datacity.org.il/

@OriHoch OriHoch assigned niryariv and unassigned OriHoch Dec 7, 2020
@niryariv
Copy link
Author

niryariv commented Dec 7, 2020

we want it to exist by default for all sites, not just when we manually set it

@OriHoch
Copy link
Contributor

OriHoch commented Dec 7, 2020

for existing instances - it will be fastest to upload the desired logo

for new instances, I'll modify the instance initialization task in this task - #156

@OriHoch OriHoch removed their assignment Dec 7, 2020
@niryariv niryariv moved this from High Priority to TODO in datacity Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niryariv niryariv

Labels
None yet
Projects
datacity
TODO
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niryariv @OriHoch