Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Migrate onto React 18 #10

Open
harshhhdev opened this issue Aug 24, 2022 · 7 comments · May be fixed by #13
Open

[FEATURE] Migrate onto React 18 #10

harshhhdev opened this issue Aug 24, 2022 · 7 comments · May be fixed by #13
Assignees
@timagixe
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
snip v1

Comments

@harshhhdev
Copy link
Owner

harshhhdev commented Aug 24, 2022 •
edited

Is your feature request related to a problem? Please describe.
Currently, we're unable to use features such as Suspense because Next.js does not support it on React versions that are below 18.

Describe the solution you'd like
I would like to upgrade this repository to use React 18.

Additional context
None.
@harshhhdev harshhhdev added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 24, 2022
@harshhhdev harshhhdev self-assigned this Aug 24, 2022
@harshhhdev harshhhdev added this to the snip v1 milestone Aug 24, 2022
@timagixe
Copy link
Contributor

Hi @harshhhdev, I would like to take a try on migrating to React v18. Could you please assign this to me?

@harshhhdev
Copy link
Owner Author

Hey @timagixe, sure thing! Feel free to open a pull request once you're ready.

@timagixe
Copy link
Contributor

@harshhhdev could you please assign it to me, so I won't miss it and could track it by the link https://github.com/issues/assigned. Thank you!

@harshhhdev harshhhdev assigned timagixe and unassigned harshhhdev Aug 25, 2022
@harshhhdev
Copy link
Owner Author

Hey @timagixe, I thought I had assigned it to you but apparently not 🤔. GitHub might've glitched. Anywho, it's assigned now. Good luck!

@timagixe
Copy link
Contributor

Hi @harshhhdev, I am taking this into work today, I will leave questions here if I face some issues or troubles.

@timagixe
Copy link
Contributor

While upgrading react to v18, I also had to upgrade framer-motion to the latest one because of TS compiler was throwing errors like this framer/motion#1573.

@timagixe timagixe linked a pull request Oct 29, 2022 that will close this issue
Open
@harshhhdev
Copy link
Owner Author

If I recall correctly, there's also an issue with Framer Motion and the types library on React 18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timagixe timagixe

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
snip v1
Development

Successfully merging a pull request may close this issue.

Migrate onto react 18 timagixe/snip
2 participants
@timagixe @harshhhdev