Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models for feature flags APIs are outdated #507

Open
rohit-cohesity opened this issue Mar 12, 2024 · 1 comment
Open

Models for feature flags APIs are outdated #507

rohit-cohesity opened this issue Mar 12, 2024 · 1 comment

Comments

@rohit-cohesity
Copy link

Hi,

We are integrating with feature-flags service in go SDK and have found following issues:

  • model_feature.go is outdated w.r.t the swagger spec hosted on this page. Furthermore, the Permanent bool json:"permanent,omitempty" property has issue due to extra whitespace, so the field is not getting set in request (and the API returns Bad Request error - "request body has an error: doesn't match the schema: Error at "/permanent": property "permanent" is missing").
  • Documentation is missing for the PUT API which was recently added to feature flags service here.
  • The PATCH API in the feature flag service seems to take *interface{} in Instructions field. This is inconvenient since there models/enums for PATCH Kind & Parameters are missing in the SDK, and we have to either manually write structs/enums or generate Harness client from the OpenAPI 3.0 Spec (which is expect to be provided by SDK).
  • The status_code 400 has not been handled in the API implementation in the feature-flags service. Furthermore, if a flag is not found in Harness, the backend returns 400 Bad Request, instead it should return 404 Not Found status. (GetFeatureFlag API)

Please address these issues, and if any clarifications are needed please do reach out.

Thank you

@rohit-cohesity
Copy link
Author

Please disregard 2nd issue (documentation related to PUT /cf/admin/features/{identifier} API)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant