Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil Safety Error Causes Process Panics #158

Closed
steve-gray opened this issue May 13, 2024 · 1 comment
Closed

Nil Safety Error Causes Process Panics #158

steve-gray opened this issue May 13, 2024 · 1 comment
Assignees

Comments

@steve-gray
Copy link

5d1c3b7

This change did not pass 2 out of 3 CI quality tests, but was merged and released in the last release. Will panic in some circumstances due to lack of null safety checks. Raised as ticket 63281 internally.

image

All of the changes in that FFM-11212 are probably subject to the same lack of nil-checking on using the * operator to dereference.

@erdirowlands
Copy link
Contributor

erdirowlands commented May 14, 2024

Hi @steve-gray apologies for this oversight. As you know, we have released a new version with the fix here https://github.com/harness/ff-golang-server-sdk/releases/tag/v0.1.23 and provided your team more info on steps we've taken to ensure we catch regressions like these in the future.
I'll go ahead and close this issue.

@erdirowlands erdirowlands self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants