Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LHCI basic auth #214

Closed
tiagosv opened this issue May 10, 2024 · 1 comment
Closed

Add support for LHCI basic auth #214

tiagosv opened this issue May 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tiagosv
Copy link

tiagosv commented May 10, 2024

Clear and concise description of the problem

I'm using a private LHCI and it has basic auth set up, which means I can't use the LHCI functionality offered by this app.
It would be great to add two extra optional CLI/CI params for username and password.

Suggested solution

Add two new cli params:

cli.option('--lhci-user <lhci-user>', 'Basic auth username of your LHCI server.')
cli.option('--lhci-pass <lhci-pass>', 'Basic auth password of your LHCI server.')

Of course there's more changes needed, but this was to exemplify more clearly what I'm talking about.

Alternative

No response

Additional context

No response

@tiagosv tiagosv added the enhancement New feature or request label May 10, 2024
@harlan-zw
Copy link
Owner

This should now be possible in v0.12.2 using --lhci-auth username:password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants