New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I always got a timeout error after request completion. #4447
Comments
Interesting. Maybe hapi doesn't properly clean up? Though it could also be a subtle node.js bug. |
My colleague got same error when run my demo. I found if I use firefox or curl command there is no error. |
Thanks. I can confirm the Chrome?? specific issue on my macOS machine using node 19. I bit of investigation with Wireshark show that Chrome opens an extra connection to the server, without sending any requests on it. This for some reason eventually triggers a node.js request timeout as you see. Hapi sends a While this is clearly a node.js error ( |
Further investigation into the node.js internals shows that it is the parser that somehow thinks that an initial request on a socket starts when the connection is opened, and not when the first packet data is received. A later pipelined request on the same connection won't trigger this issue. The request expiration logic, is triggered in an interval loop controlled by the The |
I found a likely culprit, originally introduced in nodejs/node@df08d52. While the patch also applies to node 16, the effect is only seen on v18+ since this is when the FYI this issue likely won't be exposed when hapi is running behind a reverse proxy like nginx, which is a more typical production scenario. |
@kanongil Thank your so much for your help. You are right, This issue won't exposed when running behind a reverse proxy. Is it possible to do something to avoid this error in dev environment without a reverse proxy ? I use swagger web client in Chrome. |
You should be able to get the old behaviour by setting For a more long term solution, I expect that hapi should detect this case and just silently send a 408 response, similar to what node does if there is no |
I send a request in Chrome and got the response correctly. But I always got a timeout error after about 2 minutes in the server terminal. I only got error in node 18 and windows 10, if I use node 16 there is no error.
Support plan
Context
How can we help?
This is a demo.
The text was updated successfully, but these errors were encountered: