Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust http-server: Using u32 rather then usize #354

Open
githubsands opened this issue Jan 18, 2023 · 1 comment
Open

rust http-server: Using u32 rather then usize #354

githubsands opened this issue Jan 18, 2023 · 1 comment

Comments

@githubsands
Copy link

githubsands commented Jan 18, 2023 •
edited

When looking at http-server I believe we could have a more apples to apples comparison by using a u32 or u64 sense the inputs are a positive N. In other cases for signed ints i32 or i64 may be a better comparison.

Programming-Language-Benchmarks/bench/algorithm/http-server/1.rs

Line 76 in d454527

pub value: usize,

@githubsands githubsands changed the title rust http-server: Using u32 for rather then usize rust http-server: Using u32 rather then usize Jan 18, 2023
@hanabi1224
Copy link
Owner

Thanks. I would change all other implementations to use u64, PR is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanabi1224 @githubsands