Erubis deprecated in Rails 5.1 #895

renchap · 2017-02-01T21:51:37Z

Template rendering moved to Erubi in Rails master (see rails/rails#27757), this generated a depreciation notice in the HAML gem :

rake webpacker:DEPRECATION WARNING: ActionView::Template::Handlers::Erubis is deprecated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead. (called from require at /Users/renchap/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/haml-4.0.7/lib/haml/helpers/safe_erubis_template.rb:3)```

The text was updated successfully, but these errors were encountered:

amatsuda · 2017-02-02T10:09:48Z

@renchap Could you try master and check if it's fixed? Thanks!

renchap · 2017-02-02T16:05:55Z

Seems to work fine, no more warning ! 👍

ayb · 2017-02-26T11:21:01Z

Installing 5.1.0 beta now and getting this warning. What should I do to get rid of it?

should I install haml using the master from GitHub, or a fork of master?
is there a plan for a new gem release that is more in line with master? Rubygems is showing no gem release since 2014 - https://rubygems.org/gems/haml

Appreciate your help.

amatsuda · 2017-02-26T12:08:33Z

@ayb 5.0.0.beta.2 gem is out: https://rubygems.org/gems/haml/versions/5.0.0.beta.2
Please try bundling this gem.

dhh · 2017-03-14T17:35:49Z

Would it be possible to cut a release with this fix? We're hoping to do Rails 5.1 RC1 this week and would be lovely if people using both could avoid this. Thanks!

HamptonMakes · 2017-03-16T13:13:26Z

I'm sure! @amatsuda does that sound good to you?

amatsuda · 2017-03-16T13:21:14Z

Yes, I guess we need to investigate #908, then soon I'll push 5.0.0 stable :)

vincentwoo · 2017-03-22T07:08:44Z

Would love to see this pushed soon, this is holding up my Rails 5.1 testing!

haml/haml#895

kul1 · 2017-04-17T10:37:48Z

DEPRECATION WARNING: ActionView::Template::Handlers::Erubis is deprecated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead

I have error in Rails 5.1.0 rc1 Is this supposed to be ? Don't know what to do

k0kubun · 2017-04-17T11:27:25Z

Write following code to Gemfile and execute bundle update.

gem 'haml', '5.0.0.beta.2'

kul1 · 2017-04-18T06:41:43Z

Gemfile
gem 'haml', '5.0.0.beta.2' with or w/o gem 'haml-rails'

error:

SyntaxError - syntax error, unexpected tSTRING_DEND, expecting ')'
attribute_compiler1 = ("page"}.merge(cache); case (_haml_att
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:20: syntax error, unexpected tSTRING_DEND, expecting '}'
=> _haml_attribute_compiler1 }, nil)).to_s);; when true; _ha
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:20: syntax error, unexpected ')', expecting keyword_end
ibute_compiler1 }, nil)).to_s);; when true; _hamlout.buffer 
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:20: syntax error, unexpected keyword_when, expecting ')'
< (" data-role".freeze);; when false, nil; else; _hamlout.bu
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:20: Can't assign to false
ta-role".freeze);; when false, nil; else; _hamlout.buffer <<
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:20: Can't assign to nil
le".freeze);; when false, nil; else; _hamlout.buffer << (" d
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:20: syntax error, unexpected ';', expecting '='
le".freeze);; when false, nil; else; _hamlout.buffer << (" d
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:20: syntax error, unexpected keyword_end, expecting ')'
t.buffer << ("'".freeze);; end; _hamlout.buffer << (">\n<div
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:21: syntax error, unexpected '}', expecting ')'
tribute_compiler2 = ("header"}.merge(backbtn); case (_haml_a
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:27: syntax error, unexpected keyword_ensure, expecting ')'
Util.html_safe(_erbout);ensure;@haml_buffer = @haml_buffer.u
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:27: syntax error, unexpected keyword_end, expecting ')'
ffer.upper if @haml_buffer;end;
                              ^
/Users/kul/mindapp/a241510/app/views/layouts/_full.haml:30: syntax error, unexpected keyword_end, expecting ')'
          end
             ^:
  app/views/layouts/_full.haml:20:in `'
  actionview (5.1.0.rc1) lib/action_view/template.rb:307:in `compile'

k0kubun · 2017-04-18T06:50:00Z

Oh, that seems another bug.

@kul1 Could you paste /Users/kul/mindapp/a241510/app/views/layouts/_full.haml (with some modification)? Around line 20-30.

kul1 · 2017-04-18T07:28:27Z

layouts/_full.haml

Here the Gemfile

And the code for _full.haml

!!! 5
%html
  %head
    %meta(name="viewport" content="width=device-width, minimum-scale=1, maximum-scale=1")
    = stylesheet_link_tag "application"
    = javascript_include_tag "application"
    - if GMAP
      = javascript_include_tag "http://maps.google.com/maps/api/js?sensor=false"
  %body
    = render :partial => "mindapp/menu"
    %div{"data-id" => "main", "data-role" => "panel", "data-backbtn"=>"false"}
      - if @cache
        - cache = {}
      - else
        - cache = {"data-cache"=>"never"}
      - if @backbtn
        - backbtn= {"data-backbtn"=>"true"}
      - else
        - backbtn= {"data-backbtn"=>"false"}
      %div{{"data-role" => "page"}.merge(cache) }
        %div{{"data-role" => "header"}.merge(backbtn)}
          %h1= @title || DEFAULT_TITLE
        %div{"data-role" => "content"}
          = yield

      = render :partial => "mindapp/static"

All here in Github

k0kubun · 2017-04-18T07:29:44Z

Ah, it was open source. That's very helpful :)

Maybe we have a bug in compiler for following code:
https://github.com/kul1/a241510/blob/61ba19a5a4856520a96feebd23d147fa6968e30c/app/views/layouts/_full.haml#L20-L21

I'll see that later... That might be fixed easily. Just a moment please.

This issue is reported in #895 (comment). We need extra fixes for cases like `{}[0] = {}`...

k0kubun · 2017-04-18T12:08:33Z

@kul1 Fixed this issue on master, in 5688fcc. Thank you for reporting that.

To use master branch, you may need to write:

gem 'haml', git: 'https://github.com/haml/haml'

kul1 · 2017-04-18T16:30:55Z

Worked now. Thanks

To Fixed bug reported haml/haml#895 (comment)

…ated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead.エラーを回避最新のhamlをmasterブランチから取ってきた方がいいみたいなので、Gemfileを修正参考：haml/haml#895

There was a warning message DEPRECATION WARNING: ActionView::Template::Handlers::Erubis is deprecated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead. More info: haml/haml#895

grabbing fix from haml/haml#895

Fixes deprecation: ``` DEPRECATION WARNING: ActionView::Template::Handlers::Erubis is deprecated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead. (called from <top (required)> at /Users/joerafaniello/Code/manageiq/config/application.rb:31) ``` Rails changed their default templating engine from erubis to erubi and started deprecating it in 5.1: rails/rails#27757 Even though we're only using erubis in WinRM, which is outside of actionview, we're getting the deprecation because: 1) We require hamlit in our Gemfile 2) It requires haml 3) It loads the haml railtie 4) Which loads the erubis template: https://github.com/haml/haml/blob/4.0.7/lib/haml/railtie.rb#L21 5) Which autoloads the deprecated constant: https://github.com/haml/haml/blob/4.0.7/lib/haml/helpers/safe_erubis_template.rb#L3 Haml 5.0.0 fixes this loading of the deprecated constant: haml/haml#895

Fixes deprecation warning: "ActionView::Template::Handlers::Erubis is deprecated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead.". See haml/haml#895.

amatsuda closed this as completed in 7577c18 Feb 2, 2017

teoljungberg added a commit to houndci/hound that referenced this issue Mar 25, 2017

Use HAML beta instead of adding erubis

d45aee4

haml/haml#895

k0kubun added a commit that referenced this issue Apr 18, 2017

Wrap hash to old attributes properly

5688fcc

This issue is reported in #895 (comment). We need extra fixes for cases like `{}[0] = {}`...

kul1 added a commit to kul1/mindapp that referenced this issue Apr 22, 2017

Update for Rails 5.1.0

0e0256a

To Fixed bug reported haml/haml#895 (comment)

davedash mentioned this issue May 18, 2017

Update acceptable haml requirements railsadminteam/rails_admin#2880

Closed

danielhum added a commit to danielhum/haml4r that referenced this issue May 16, 2018

Rails 5 compatibility fix

512591e

grabbing fix from haml/haml#895

vemv mentioned this issue Aug 29, 2018

action_dispatch/middleware/stack.rb: can't modify frozen Array rails/rails#33745

Closed

jrafanie mentioned this issue Jun 14, 2019

Use erubi instead of erubis, upgrade haml/haml_lint ManageIQ/manageiq#18868

Closed

NickLaMuro mentioned this issue May 8, 2020

Upgrade rubocop to v0.82.0 and haml_lint to v0.35.0 ManageIQ/miq_bot#498

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Erubis deprecated in Rails 5.1 #895

Erubis deprecated in Rails 5.1 #895

renchap commented Feb 1, 2017

amatsuda commented Feb 2, 2017

renchap commented Feb 2, 2017

ayb commented Feb 26, 2017

amatsuda commented Feb 26, 2017

dhh commented Mar 14, 2017

HamptonMakes commented Mar 16, 2017

amatsuda commented Mar 16, 2017

vincentwoo commented Mar 22, 2017

kul1 commented Apr 17, 2017

k0kubun commented Apr 17, 2017

kul1 commented Apr 18, 2017 •

edited

k0kubun commented Apr 18, 2017

kul1 commented Apr 18, 2017

k0kubun commented Apr 18, 2017 •

edited

k0kubun commented Apr 18, 2017

kul1 commented Apr 18, 2017

Erubis deprecated in Rails 5.1 #895

Erubis deprecated in Rails 5.1 #895

Comments

renchap commented Feb 1, 2017

amatsuda commented Feb 2, 2017

renchap commented Feb 2, 2017

ayb commented Feb 26, 2017

amatsuda commented Feb 26, 2017

dhh commented Mar 14, 2017

HamptonMakes commented Mar 16, 2017

amatsuda commented Mar 16, 2017

vincentwoo commented Mar 22, 2017

kul1 commented Apr 17, 2017

k0kubun commented Apr 17, 2017

kul1 commented Apr 18, 2017 • edited

k0kubun commented Apr 18, 2017

kul1 commented Apr 18, 2017

k0kubun commented Apr 18, 2017 • edited

k0kubun commented Apr 18, 2017

kul1 commented Apr 18, 2017

kul1 commented Apr 18, 2017 •

edited

k0kubun commented Apr 18, 2017 •

edited