Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package-only for release/N.x branches? #147

Open
alexreinking opened this issue Feb 14, 2021 · 2 comments
Open

Package-only for release/N.x branches? #147

alexreinking opened this issue Feb 14, 2021 · 2 comments

Comments

@alexreinking
Copy link
Member

alexreinking commented Feb 14, 2021

The fully-merged release branch builds do a significant amount of redundant work with:

  1. The PRs that got merged to trigger the update to the branch in the first place (the code is identical)
  2. Internally with the build and package steps

I propose only running package steps and then testing the apps on the package directly. If there are issues, we can fail. If the tests in test/{correctness,generator,...} were fully externalized, those could be run against the actual package, too.

On the other hand, maybe this is orthogonal and we should remove the package steps from release-branch-builders and run them on-demand from the buildbot website when we're ready to cut a release.

Basically, I want to make sure our buildbots are doing useful work when they test master, release/N.x, etc. and that it gets us some value beyond the PR testers.

@steven-johnson
Copy link
Contributor

SGTM. TBH, though, if all this is only happening when we do release backports (ie, rarely), how much of a problem is it?

@alexreinking
Copy link
Member Author

alexreinking commented Feb 16, 2021

It's a bit more of a problem because that's exactly when latency is the most annoying. The backport gets merged and we might fairly quickly want to issue a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants