Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some CMake issues regarding Flatbuffers #7757

Open
3 tasks
steven-johnson opened this issue Aug 11, 2023 · 0 comments · May be fixed by #7794
Open
3 tasks

Fix some CMake issues regarding Flatbuffers #7757

steven-johnson opened this issue Aug 11, 2023 · 0 comments · May be fixed by #7794
Assignees

Comments

@steven-johnson
Copy link
Contributor

#7594 is landing with a few CMake issues that could be improved:

  • use the NAMES option for find_package() to deal with case sensitivity
  • remove unnecessary GENERATED property setting
  • Upgrade to CMake 3.24 to avoid a lot of FetchContent sadness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants