Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

found 1 moderate severity vulnerability? (npm install > audit) #427

Open
wibrt opened this issue Apr 23, 2020 · 3 comments
Open

found 1 moderate severity vulnerability? (npm install > audit) #427

wibrt opened this issue Apr 23, 2020 · 3 comments

Comments

@wibrt
Copy link

wibrt commented Apr 23, 2020

npm install

After running
$ npm install -G create-elm-app
i get the output:

..
+ create-elm-app@4.2.8
added 1299 packages from 773 contributors and audited 15279 packages in 80.205s
..
found 1 moderate severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details

Running npm audit manually does not work

npm ERR! code EAUDITNOPJSON
npm ERR! audit No package.json found: Cannot audit a project without a package.json

Versions

  1. node -v: v10.15.2

  2. npm -v: 4.14.3

  3. npm ls create-elm-app -g (if you haven’t ejected):
    /usr/local/lib
    └── (empty)

Then, specify:

  1. Operating system: Debian GNU/Linux 10 (buster)

Steps to Reproduce

npm install -G create-elm-app

@halfzebra
Copy link
Owner

Hi @wibrt!

Thanks for raising awareness! 👍
The vulnerability is originated in https://github.com/webpack-contrib/uglifyjs-webpack-plugin, which is currently providing a better minimization rate for JS produced by Elm.

We can definitely fix this by switching to a well-maintained https://github.com/webpack-contrib/terser-webpack-plugin, which would slightly increase the asset size.

Are you interested in working on a fix for this?

@wibrt
Copy link
Author

wibrt commented May 11, 2020

unfortunately no dev background with (create-)elm(-app) nor time at the moment

@halfzebra
Copy link
Owner

No worries!

I will see how this can be solved. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants