Fix chunked data bug in embedded version of WsgiDAV (affects big files, as well as all files from some dav clients) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* support range * copy SeafileStream to seafdav and add lock for block_map * Fixed SeafileStream
* handle error * remove redundant code
Co-authored-by: 杨赫然 <heran.yang@seafile.com>
* Use sha1 algorithm to validate sercret * Don't need to filter value * Get option_val from options_useroptions Co-authored-by: yangheran <heran.yang@seafile.com>
…all grammar mistakes
check if file number exceeds limit when upload file
make `workers` parameter work
Lower SGI layer already decoded the chunks. The fix was taken from mar10/wsgidav@dd3e53a
imwhatiam
force-pushed
the
master
branch
2 times, most recently
from
b4332f9
to
057a88a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: haiwen/seafile#2723 (comment)
Description: The currently embedded version of WsgiDAV is 4.1.0 which has a bug for chunked data. This PR fixes the problem for the embedded WsgiDAV. This is an instant drop-in replacement, so it's instant to incorporate. Upgrading WsgiDAV to 4.3.0 (which does fix the bug) may braek compatibility with the existing Seafile integration so devs may need more time before making that upgrade.