Debug output in binary releases

[lawgsy]

It appears there is debug output left in the binary releases. If not slowing the app down, it will obscure plugin development debugging.

For example, (line 143 in renderer/app), which displays a lot of debugging information.
console.log('app.jsx -> rpc(requestAddResults), ticket=%s, type=%s, payload=%o', ticket, type, payload);

Perhaps a 'debug/production' flag could be used to disable the logger in general - or rather using a different debug logger for the main application so it will not interfere with plugin development.

[cpriest]

That may be my fault, looks like something I might have put in while debugging something.

[dannya]

@lawgsy @cpriest I've removed the specific mentioned instance of this in my latest merge to develop, but I'd like to check more in the next built version what the status of this is, mostly if the other [hain-search] type logging output is also present (like it is if you run the development version locally).

If so, I will implement some kind of flag to prevent this in the built version.

[cpriest]

As far as I know, it is present in the release version. If the release version was changed so that Winston doesn't log console output to the stdout/stderr (but still to dev console), that would be ideal.

I write other browser plugins and having some debug output when things go wrong in the wild can be invaluable.