Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add a mask to the color matcher module #6

Open
Ir1d opened this issue Sep 28, 2022 · 2 comments
Open

Is it possible to add a mask to the color matcher module #6

Ir1d opened this issue Sep 28, 2022 · 2 comments

Comments

@Ir1d
Copy link

Ir1d commented Sep 28, 2022

Hi!

Thanks for the great work! I'm wondering if I can add a mask onto the color matcher module to perform a local/regional color transfer.

@hahnec
Copy link
Owner

hahnec commented Sep 29, 2022

Hello,

I can see the idea behind this. Wouldn't it be sufficient to mask with an alpha channel (e.g., using a png image), then let the algorithm do the job and combine masked regions afterwards?

@Ir1d
Copy link
Author

Ir1d commented Sep 29, 2022

Thanks for the prompt reply. I'm running it on some png images with transparent regions, and it sometimes seems the result color overflows and is not very stable. I've implemented a masked version of color-matcher (mkl solver) on my side. If the result is promising, I'll do a pr, but it's still not very good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants